WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit f8ada9d

Browse files
committed
fix tests
Signed-off-by: Cassandra Coyle <[email protected]>
1 parent 662cc1a commit f8ada9d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/version/version_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ func TestGetVersionsGithub(t *testing.T) {
210210
}
211211
m := http.NewServeMux()
212212
s := http.Server{Addr: ":12345", Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
213+
defer s.Close()
213214

214215
for _, tc := range tests {
215216
body := tc.ResponseBody
@@ -319,6 +320,7 @@ entries:
319320
}
320321
m := http.NewServeMux()
321322
s := http.Server{Addr: ":12346", Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
323+
defer s.Close()
322324

323325
for _, tc := range tests {
324326
body := tc.ResponseBody

tests/e2e/common/common_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func TestGetVersionedNumberOfPods(t *testing.T) {
4545
name: "HA disabled with latest version",
4646
isHAEnabled: false,
4747
details: VersionDetails{UseDaprLatestVersion: true},
48-
expectedNumber: numNonHAPodsWithScheduler,
48+
expectedNumber: numNonHAPodsWithHAScheduler,
4949
expectedError: false,
5050
},
5151
{
@@ -94,7 +94,7 @@ func TestGetVersionedNumberOfPods(t *testing.T) {
9494
name: "HA disabled with new RC version",
9595
isHAEnabled: false,
9696
details: VersionDetails{UseDaprLatestVersion: false, RuntimeVersion: "1.15.0-rc.1"},
97-
expectedNumber: numNonHAPodsWithScheduler,
97+
expectedNumber: numNonHAPodsWithHAScheduler,
9898
expectedError: false,
9999
},
100100
}

0 commit comments

Comments
 (0)