postgresql 13 - colliculocale

[Dominique57]

Hi how are you doing ?

I just saw that you are creating a new repo for your database utils, and wanted to test the database diff 😄
(I don't know which postgresql version you aim to target, but i will still inform you of the following)

I tried it with :

• python3.11.2
• postgresql13
• your repo @ adeca16

I encountered 2 issues :

• According to my understanding of postgresql doc, colliculocale only exists in postgresql 15,16, then got renamed in postgresql 17+
  I didn't find a column in psql14 or older
  I managed to get it working by adding a -- 15_AND_LATER guard after the existing -- 16_AND_EARLIER, (and reworking the commas) effectively targeting only 15,16 , however i am not sure how the empty local field is going to behave ? It doesn't looks like it is being used
  

  results/results/schemainspect/pg/sql/collations.sql

  Line 15 in adeca16

  -- 16_AND_EARLIER colliculocale as locale

• In

  results/results/schemainspect/misc.py

  Line 79 in adeca16

  module_name = external_caller()

  I have the issue where the code returns schemainspect.misc.pg.obj instead of schemainspect.misc.pg.
  For testing purposes I basically removed the last part, and it is working. However i am not very familiar with python's importlib usage, and have not yet dug in the problem to understand what is going on.

I never tried migra before, but it is honestly the first tool that actually works as i want, it's really cool !
I am planning to use it to store my code as schema, migrations hand-written (maybe inspired byt results output) on the side and use your tool in CI to ensure that my migrations do generate an identical database as my updated schema 👍

Thanks

[djrobstep]

Awesome, glad you like it! I will take a look at these and roll out fixes soon!