WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Validation of Output Module Label during Workflow creation #11171

@germanfgv

Description

@germanfgv

Impact of the new feature
WMAgent, T0Agent

Is your feature request related to a problem? Please describe.
T0 production agent was unable to upload blocks of AlCa producers PromptCalibProdSiPixelLorentzAngle and PromptCalibProdSiStripHitEfficiency because the length of the name of their associated output module label was greater than the 45 characters limit in DBS database. A proper validation of such DBS constraints would have prevented this error to reach production configuration.

https://cms-talk.web.cern.ch/t/alcaprompt-datasets-not-loaded-in-dbs/11146

Describe the solution you'd like
Add checks on validateWorkload(), either on StdBase.py, or in PromptReco.py and Express.py.

I'd argue that this should be validated to all kinds of workflows, so I think it makes more sense to add these checks on StdBase.validateWorkload()

Describe alternatives you've considered
We already have masterValidation() to validate input arguments. So it would be possible to simply check the length of the alca skims there. Nonetheless, that would not have a direct correlation with the DBS schema, and it would also not prevent other modules to surpass the 45 char limit

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions