WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 1a8b095

Browse files
committed
PlatformBootManagerLib: Remove stale FvFile(s) before registering boot keys
Firmware updates can invalidate existing FvFile entries. Attempting to clean them up after registering the boot keys (e.g. ESC) often leads to the keys not working until after a reboot - perhaps because the options they reference no longer match? Signed-off-by: Mario Bălănică <[email protected]>
1 parent 519a6f7 commit 1a8b095

File tree

1 file changed

+2
-2
lines changed
  • edk2-rockchip/Silicon/Rockchip/Library/PlatformBootManagerLib

1 file changed

+2
-2
lines changed

edk2-rockchip/Silicon/Rockchip/Library/PlatformBootManagerLib/PlatformBm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -751,6 +751,8 @@ PlatformRegisterOptionsAndKeys (
751751

752752
GetPlatformOptions ();
753753

754+
RemoveStaleFvFileOptions ();
755+
754756
//
755757
// Register ENTER as CONTINUE key
756758
//
@@ -798,8 +800,6 @@ PlatformRegisterOptionsAndKeys (
798800
F4.ScanCode = SCAN_F4;
799801
F4.UnicodeChar = CHAR_NULL;
800802
PlatformRegisterFvBootOption (&gRockchipMaskromResetFileGuid, L"Reset to MaskROM", 0, &F4);
801-
802-
RemoveStaleFvFileOptions ();
803803
}
804804

805805
//

0 commit comments

Comments
 (0)