-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Synthetics] Add global params sync internal API !! #239284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
justinkambic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I tested this by modifying values on the server and calling the API routes. Did have one super nit callout.
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.19, 9.2 |
## Summary
These two endpoints are added to provide bit more control around the
sync task functionality, they are currently not being used in UI.
Following two endpoints have been added to be used internally !!
`/internal/synthetics/sync_global_params`
This will trigger syncing of global params to private locations.
```
`PUT /internal/synthetics/sync_global_params/_settings`
{
enable: false
}
```
This can be used to disable/enable the task which performs auto syncing
of global params to private locations.
---------
Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit d40cdc4)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary
These two endpoints are added to provide bit more control around the
sync task functionality, they are currently not being used in UI.
Following two endpoints have been added to be used internally !!
`/internal/synthetics/sync_global_params`
This will trigger syncing of global params to private locations.
```
`PUT /internal/synthetics/sync_global_params/_settings`
{
enable: false
}
```
This can be used to disable/enable the task which performs auto syncing
of global params to private locations.
---------
Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit d40cdc4)
# Conflicts:
# x-pack/solutions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.test.ts
…245601) # Backport This will backport the following commits from `main` to `8.19`: - [[Synthetics] Add global params sync internal API !! (#239284)](#239284) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-12-09T08:45:43Z","message":"[Synthetics] Add global params sync internal API !! (#239284)\n\n## Summary\n\nThese two endpoints are added to provide bit more control around the\nsync task functionality, they are currently not being used in UI.\n\nFollowing two endpoints have been added to be used internally !!\n\n`/internal/synthetics/sync_global_params`\n\nThis will trigger syncing of global params to private locations. \n\n\n```\n`PUT /internal/synthetics/sync_global_params/_settings`\n{\n\tenable: false\n}\n```\n\nThis can be used to disable/enable the task which performs auto syncing\nof global params to private locations.\n\n---------\n\nCo-authored-by: Dominique Clarke <[email protected]>\nCo-authored-by: Justin Kambic <[email protected]>","sha":"d40cdc43feac6995a0036c0b80d59584fea874be","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:actionable-obs","backport:version","author:obs-ux-management","v8.19.6","Team:obs-ux-management","v9.2.3","v8.19.9"],"title":"[Synthetics] Add global params sync internal API !!","number":239284,"url":"https://github.com/elastic/kibana/pull/239284","mergeCommit":{"message":"[Synthetics] Add global params sync internal API !! (#239284)\n\n## Summary\n\nThese two endpoints are added to provide bit more control around the\nsync task functionality, they are currently not being used in UI.\n\nFollowing two endpoints have been added to be used internally !!\n\n`/internal/synthetics/sync_global_params`\n\nThis will trigger syncing of global params to private locations. \n\n\n```\n`PUT /internal/synthetics/sync_global_params/_settings`\n{\n\tenable: false\n}\n```\n\nThis can be used to disable/enable the task which performs auto syncing\nof global params to private locations.\n\n---------\n\nCo-authored-by: Dominique Clarke <[email protected]>\nCo-authored-by: Justin Kambic <[email protected]>","sha":"d40cdc43feac6995a0036c0b80d59584fea874be"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/245599","number":245599,"state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
…245599) # Backport This will backport the following commits from `main` to `9.2`: - [[Synthetics] Add global params sync internal API !! (#239284)](#239284) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-12-09T08:45:43Z","message":"[Synthetics] Add global params sync internal API !! (#239284)\n\n## Summary\n\nThese two endpoints are added to provide bit more control around the\nsync task functionality, they are currently not being used in UI.\n\nFollowing two endpoints have been added to be used internally !!\n\n`/internal/synthetics/sync_global_params`\n\nThis will trigger syncing of global params to private locations. \n\n\n```\n`PUT /internal/synthetics/sync_global_params/_settings`\n{\n\tenable: false\n}\n```\n\nThis can be used to disable/enable the task which performs auto syncing\nof global params to private locations.\n\n---------\n\nCo-authored-by: Dominique Clarke <[email protected]>\nCo-authored-by: Justin Kambic <[email protected]>","sha":"d40cdc43feac6995a0036c0b80d59584fea874be","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:actionable-obs","backport:version","author:obs-ux-management","v8.19.6","Team:obs-ux-management","v9.2.3","v8.19.9"],"title":"[Synthetics] Add global params sync internal API !!","number":239284,"url":"https://github.com/elastic/kibana/pull/239284","mergeCommit":{"message":"[Synthetics] Add global params sync internal API !! (#239284)\n\n## Summary\n\nThese two endpoints are added to provide bit more control around the\nsync task functionality, they are currently not being used in UI.\n\nFollowing two endpoints have been added to be used internally !!\n\n`/internal/synthetics/sync_global_params`\n\nThis will trigger syncing of global params to private locations. \n\n\n```\n`PUT /internal/synthetics/sync_global_params/_settings`\n{\n\tenable: false\n}\n```\n\nThis can be used to disable/enable the task which performs auto syncing\nof global params to private locations.\n\n---------\n\nCo-authored-by: Dominique Clarke <[email protected]>\nCo-authored-by: Justin Kambic <[email protected]>","sha":"d40cdc43feac6995a0036c0b80d59584fea874be"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]> Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: Justin Kambic <[email protected]>
Summary
These two endpoints are added to provide bit more control around the sync task functionality, they are currently not being used in UI.
Following two endpoints have been added to be used internally !!
/internal/synthetics/sync_global_paramsThis will trigger syncing of global params to private locations.
This can be used to disable/enable the task which performs auto syncing of global params to private locations.