-
Notifications
You must be signed in to change notification settings - Fork 606
fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner #7557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner #7557
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (12.76%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7557 +/- ##
==========================================
- Coverage 72.43% 72.39% -0.04%
==========================================
Files 232 232
Lines 34307 34373 +66
==========================================
+ Hits 24849 24884 +35
- Misses 7682 7715 +33
+ Partials 1776 1774 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hey @y-rabie I agree with the overall logic here, suggesting improvements in the algo to avoid the nested for loops
|
|
@arkodg Apologies I don't think I get what you're saying. Can you illustrate further? |
|
Hi @y-rabie I guess this is what @arkodg is asking about (please correct me if I'm misunderstanding anything @arkodg 🙂 ) : Optimize the current two-level loop by using a map, reducing the lookup of the inner loop from O(n) to O(1), and avoid consuming more memories by storing ptr to the original status instead of copying its value. |
e5e5925 to
878cec5
Compare
Signed-off-by: y-rabie <[email protected]>
878cec5 to
f8dd034
Compare
First PR split of #7307. Includes only changes in the gateway-api runner.
E2e tests are included in the second PR.