WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Dec 2, 2025

make access log formatter (e.g. %UPSTREAM_HOST%) supported in Literal type tag

@zirain zirain requested a review from a team as a code owner December 2, 2025 02:20
@arkodg
Copy link
Contributor

arkodg commented Dec 2, 2025

just realized that the field has a type:Literal union discriminator associated with it, so reusing it for Formatter doesnt make much sense

should we deprecate the customTags field and use something like looks more like map[string]string ?

@zirain
Copy link
Member Author

zirain commented Dec 2, 2025

just realized that the field has a type:Literal union discriminator associated with it, so reusing it for Formatter doesnt make much sense

should we deprecate the customTags field and use something like looks more like map[string]string ?

CustomTags map[string]CustomTag `json:"customTags,omitempty"`

CustomTags is a map.

Signed-off-by: zirain <[email protected]>
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.33%. Comparing base (7864465) to head (d2bed3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7640      +/-   ##
==========================================
- Coverage   72.33%   72.33%   -0.01%     
==========================================
  Files         232      232              
  Lines       34143    34141       -2     
==========================================
- Hits        24699    24696       -3     
  Misses       7669     7669              
- Partials     1775     1776       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants