Returning max delay value that is uint-wrap around safe.

dok-net · dok-net · commit f05cb5435e55 · 2023-07-19T02:32:50.000+02:00
diff --git a/cores/esp8266/Schedule.cpp b/cores/esp8266/Schedule.cpp
@@ -143,7 +143,7 @@ bool schedule_recurrent_function_us(const std::function<bool(void)>& fn,
 
 uint32_t get_scheduled_recurrent_delay_us()
 {
-    if (!rFirst) return ~static_cast<uint32_t>(0);
+    if (!rFirst) return ~static_cast<decltype(micros())>(0) >> 1;
     // handle already expired rTarget.
     const int32_t remaining = rTarget - micros();
     return (remaining > 0) ? static_cast<uint32_t>(remaining) : 0;

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ bool schedule_recurrent_function_us(const std::function<bool(void)>& fn,`
`143`	`143`
`144`	`144`	`uint32_t get_scheduled_recurrent_delay_us()`
`145`	`145`	`{`
`146`		`- if (!rFirst) return ~static_cast<uint32_t>(0);`
	`146`	`+ if (!rFirst) return ~static_cast<decltype(micros())>(0) >> 1;`
`147`	`147`	`// handle already expired rTarget.`
`148`	`148`	`const int32_t remaining = rTarget - micros();`
`149`	`149`	`return (remaining > 0) ? static_cast<uint32_t>(remaining) : 0;`