Set `last-call-deadline` in the preamble before merging relevant pull requests

[SamWilsn]

Originally from #55

Immediately before merging (IMO, ideally in the merge commit itself) set last-call-deadline in the preamble to 14 days after the merge date.

[MicahZoltu]

I'm weakly against this one because last call is 14 days minimum, but unlimited maximum. Some authors like to give a longer last call, and core EIPs have a last call that runs until mainnet launch generally.

[MicahZoltu]

Perhaps, if last call is missing automatically add it with 14 day window, if it is present then do nothing?

[SamWilsn]

How about:

• If the last call deadline is missing: set it to merge date plus 14 days.
• If the last call deadline is present, but sooner than 14 days plus the merge date: set it to merge date plus 14 days.
• If the last call deadline is present, and is later than 14 days plus the merge date: leave untouched.

[JEAlfonsoP]

could you please review this issue against 53. ? I believe 53 covers both, time and editors approval.
If this is the case I will make a PR following Issue 53 to cover both.

[MicahZoltu]

#53 is different. This suggestion is about making the bot add/adjust the last call deadline header field. #53 is about changing the number of editors required to change EIP-1.

[JEAlfonsoP]

Ok. Roger that.

where would you like last-call-deadline to be added (or where normally is added, I do not see it in the EIP-1 template):

eip:
title: <The EIP title is a few words, not a complete sentence>
description: <Description is one full (short) sentence>
author: <a comma separated list of the author's or authors' name + GitHub username (in parenthesis), or name and email (in angle brackets).
discussions-to:
status: Draft
type: <Standards Track, Meta, or Informational>
category (*only required for Standards Track): <Core, Networking, Interface, or ERC>
created: <date created on, in ISO 8601 (yyyy-mm-dd) format>
requires (*optional): <EIP number(s)>

[MicahZoltu]

After status line.

...
status: Last Call
last-call-deadline: YYYY-MM-DD
type: Core
...

[JEAlfonsoP]

is anybody working on it ?

[Pandapip1]

Nope, go ahead! This might end up being a separate project though, so don't spend too much time on it.

[JEAlfonsoP]

Ok.

[JEAlfonsoP]

How about:

• If the last call deadline is missing: set it to merge date plus 14 days.
• If the last call deadline is present, but sooner than 14 days plus the merge date: set it to merge date plus 14 days.
• If the last call deadline is present, and is later than 14 days plus the merge date: leave untouched.

Question: Should EIP-Bot follows the above If's ?

[Pandapip1]

Yes, but see my comment #65 (comment)