Is the release of 1.2.0 correct?

[nodepond]

I have an issue, when I try to install @react-pdf/renderer, read about it here: diegomura/react-pdf#643

After doing some research, I have the suspicion, that with the release of 1.2.0 maybe something went wrong. In the example above, the @render-pdf/fontkit wants to import the StateMachine from index.js of this repo in the node_modules folder. At the 1.2.0 version the compiler (i.e. webpack) complains, that it is unable to import the StateMachine correctly.

When I use the contents of the older (1.1.0) index.js from node_modules the project compiles and runs without any problems.

Can someone confirm this? Or am I doing something horrible wrong? I guess, there might be some issues in the compile-section of the 1.2.0 release.

[devongovett]

This was the change: eed4375

cc @blikblum

[devongovett]

What error do you get @nodepond?

[nodepond]

I tried to compile with @react-pdf/renderer. This is the webpack-error:

ERROR in ./node_modules/@react-pdf/fontkit/dist/fontkit.browser.es.js 8713:23-35 "export 'default' (imported as 'StateMachine') was not found in 'dfa'

Here the complete bug-report: diegomura/react-pdf#643

[blikblum]

Seems that @react-pdf is doing a custom build of fontkit since there's no fontkit.browser.es.js file in official release (1.8.0).

This error occurs when trying to import a common js module using native es module import.

Look at fontkit.browser.es.js and see how dfa is imported:

import StateMachine from 'dfa'

or

var StateMachine = require('dfa')

or

var StateMachine = _interopDefault(require('dfa')); // like fontkit 1.8.0

The later two should work

[devongovett]

Cc @diegomura

[blikblum]

Also, dfa 1.1 and 1.2 is exporting StateMachine the same way:

module.exports = StateMachine;

So should not be difference regarding this issue

[wernerfinck]

Hi,
Do you have any other suggestions to face this issue ?
I tried to downgrade to dfa 1.1.0,
and i also tried to change the import of dfa in @react-pdf fontkit.browser.es.js file (following the @blikblum instructions)
but the bug is remaining...

[wernerfinck]

finally i had to:

• import dfa StateMachine like this
  var StateMachine = require('dfa')
  in react-pdf's node-module fontkit.browser.es.js file

• add sourceType: 'unambiguous' in babel.config.js

[relightme]

I have this issue too while using react-pdf.

Perhaps need to add IE to the list of browsers in .babelrc
"browsers": [ "Firefox 57", "Chrome 60", "iOS 10", "Safari 10" ]

In yarn.lock with
dfa@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/dfa/-/dfa-1.1.0.tgz#d30218bd10d030fa421df3ebbc82285463a31781" integrity sha1-0wIYvRDQMPpCHfPrvIIoVGOjF4E= dependencies: babel-runtime "^6.11.6"

it works great, instead of:

dfa@^1.0.0: version "1.2.0" resolved "https://registry.yarnpkg.com/dfa/-/dfa-1.2.0.tgz#96ac3204e2d29c49ea5b57af8d92c2ae12790657" integrity sha512-ED3jP8saaweFTjeGX8HQPjeC1YYyZs98jGNZx6IiBvxW7JG5v492kamAQB3m2wop07CvU/RQmzcKr6bgcC5D/Q==

My app crashes on IE11 and it's impossible to create a build of the app with error:

SCRIPT1002: Syntax error
class StateMachine {...
^^^^

Failed to compile.
Failed to minify the code from this file:
./node_modules/dfa/index.js:10
Read more here: http://bit.ly/2tRViJ9

[parkerSmith725]

I have this issue too while using react-pdf.
My app crashes on IE11 and it's impossible to create a build of the app with error:

SCRIPT1002: Syntax error
class StateMachine {...
^^^^

I'm having the same issue as @relightme above. App is crashing on IE11 with the same syntax error, dfa is being imported by @react-pdf/renderer. Is there a resolution for this?

Thanks in advance!

[rdebeasi]

I'm also experiencing IE11 problems similar to the ones described above. Rolling back from 1.2.0 to 1.1.0 resolves the issue. I've filed #4 to make the build settings more like they were v1.1.0 and restore compatibility with older browsers.

Does the code in this PR resolve the problems that folks in this thread are having?

[rdebeasi]

Does anyone have time to test #4 using npm link and let us know whether these changes resolve the issues that you're experiencing? Thank you in advance! 😄 🚀

[PierreAndreis]

This dependency was failing es-check es5 check on my project.

Rolling back to 1.1.0 solved it. Using #4 didn't for some reason... Got this error on the build process.

Module not found: Error: Can't resolve 'dfa' in 'node_modules/@react-pdf/fontkit/dist'
 @ node_modules/@react-pdf/fontkit/dist/fontkit.browser.es.js 6:0-31 8428:23-35 9363:25-37
 @ node_modules/@react-pdf/renderer/dist/react-pdf.browser.es.js

[gazpachu]

Also not working for me in IE11