chore(Employee Referral): Better Feedback message

Author: asmitahase

hrms/hr/doctype/employee_referral/employee_referral.py

@@ -19,10 +19,15 @@ def validate(self):
 		self.set_referral_bonus_payment_status()
 
 	def validate_unique_referral(self):
-		if frappe.db.exists(
+		if referral := frappe.db.exists(
 			"Employee Referral", {"name": ("!=", self.name), "email": self.email, "docstatus": ("!=", 2)}
 		):
-			frappe.throw("Referral for this email already exists.")
+			frappe.throw(
+				_("Employee Referral {0} already exists for email: {1}").format(
+					get_link_to_form("Employee Referral", referral), frappe.bold(self.email)
+				),
+				frappe.DuplicateEntryError,
+			)
 
 	def set_full_name(self):
 		self.full_name = " ".join(filter(None, [self.first_name, self.last_name]))

hrms/hr/doctype/employee_referral/test_employee_referral.py

@@ -58,7 +58,7 @@ def test_status_on_discard(self):
 
 	def test_unique_referral(self):
 		referral_1 = create_employee_referral(email="[email protected]")
-		self.assertRaises(frappe.ValidationError, create_employee_referral, email="[email protected]")
+		self.assertRaises(frappe.DuplicateEntryError, create_employee_referral, email="[email protected]")
 		referral_1.cancel()
 		referral_2 = create_employee_referral(email="[email protected]")
 		self.assertTrue(referral_2)