WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@phot0n
Copy link
Member

@phot0n phot0n commented Dec 5, 2025

  • static ip on primary
  • static ip on secondary
  • add validation for having static ip on atleast one of the proxy server (for failover)

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.89%. Comparing base (76f69ad) to head (2bbcf8d).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ess/press/doctype/proxy_failover/proxy_failover.py 50.00% 10 Missing ⚠️
press/api/account.py 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4108      +/-   ##
===========================================
- Coverage    44.89%   44.89%   -0.01%     
===========================================
  Files          726      726              
  Lines        49737    49733       -4     
===========================================
- Hits         22331    22329       -2     
+ Misses       27406    27404       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 347 to 358
for team in teams:
doc = frappe.new_doc("Dashboard Banner")
doc.enabled = 1
doc.title = "Proxy Failover"
doc.type = "Warning"
doc.is_scheduled = 1
doc.scheduled_start_time = frappe.utils.now()
doc.scheduled_end_time = frappe.utils.add_to_date(hours=6)
doc.message = message
doc.type_of_scope = "Team"
doc.team = team
doc.insert(ignore_permissions=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hate this - need to make the dashboard banner thing decent for bulk sites, teams, servers

@phot0n phot0n changed the title fix: misc (proxy failover) fix: Misc (proxy failover) Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant