WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fix: Handle new site creation failure #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AyshaHakeem wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: Handle new site creation failure #4110

AyshaHakeem wants to merge 5 commits into from
+73 −4

Conversation

@AyshaHakeem
Copy link
Collaborator

@AyshaHakeem AyshaHakeem commented Dec 5, 2025

@AyshaHakeem
fix: Add creation_failed field to Site doctype
b474b84 
- Set creation_failed when 'New Site' or 'New Site from Backup' fails
- Update @site_action to block all actions except archive and restore when creation_failed is enabled
- Clear creation_failed after a successful restore
@AyshaHakeem
fix: Add dashboard banner to inform user about site creation failure
01d91e1
@AyshaHakeem AyshaHakeem marked this pull request as draft December 5, 2025 08:55
@AyshaHakeem AyshaHakeem marked this pull request as ready for review December 5, 2025 09:19
@codecov
Copy link

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.88%. Comparing base (76f69ad) to head (0d95b27).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/site/site.py 28.57% 15 Missing ⚠️

❌ Your patch check has failed because the patch coverage (28.57%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4110      +/-   ##
===========================================
- Coverage    44.89%   44.88%   -0.02%     
===========================================
  Files          726      726              
  Lines        49737    49753      +16     
===========================================
- Hits         22331    22330       -1     
- Misses       27406    27423      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

regdocs
regdocs reviewed Dec 5, 2025
View reviewed changes
press/press/doctype/site/site.json
"modified": "2025-10-07 19:14:24.341019",
"modified_by": "Administrator",
"modified": "2025-12-05 13:49:05.307868",
"modified_by": "[email protected]",
Copy link
Member

@regdocs regdocs Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really an issue but workspace email in the codebase makes me uneasy 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regdocs regdocs regdocs approved these changes

@balamurali27 balamurali27 Awaiting requested review from balamurali27 balamurali27 is a code owner

Assignees

No one assigned

Labels

backport-master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AyshaHakeem @regdocs