WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@phot0n
Copy link
Member

@phot0n phot0n commented Dec 6, 2025

  • probably dont allow editing a scheduled update if it has been cancelled? (check siteupdatedialog.vue) -- there is a check for status to be scheduled so it should be fine for the most part i guess

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.89%. Comparing base (76f69ad) to head (132d6da).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/site_update/site_update.py 33.33% 10 Missing ⚠️
press/press/doctype/site/site.py 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.29%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4123      +/-   ##
===========================================
- Coverage    44.89%   44.89%   -0.01%     
===========================================
  Files          726      725       -1     
  Lines        49737    49738       +1     
===========================================
- Hits         22331    22330       -1     
- Misses       27406    27408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@phot0n phot0n force-pushed the vdr-dashboard branch 3 times, most recently from b9bb46c to 9ef0f94 Compare December 6, 2025 18:03
@phot0n phot0n changed the title fix: mark site update doc as cancelled when cancelling an update rather than deleting it fix: Mark site update doc as cancelled when cancelling an update rather than deleting it Dec 6, 2025
@phot0n phot0n marked this pull request as ready for review December 6, 2025 18:07
@phot0n phot0n requested a review from balamurali27 as a code owner December 6, 2025 18:07
@phot0n phot0n marked this pull request as draft December 6, 2025 18:09
@phot0n phot0n marked this pull request as ready for review December 6, 2025 18:25
@phot0n
Copy link
Member Author

phot0n commented Dec 6, 2025

@phot0n phot0n force-pushed the vdr-dashboard branch 2 times, most recently from f74763e to be53fe6 Compare December 6, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant