WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Many unit tests for AssessPhasing rely on a broken test fixture #1050

@clintval

Description

@clintval

The test fixture used to create a single-interval IntervalList, despite allowing parameterization, always returns an interval in the range [1, 10]. Fixing this bug causes many unit tests to fail. Either the implementation of AssessPhasing is incorrect or the test cases were create improperly such that they assert incorrect expected test outcomes.

private def toIntervalList(start: Int, end: Int): PathToIntervals = {
val path = makeTempFile("AssessPhasingTest.", ".interval_list")
val contig = Header.getSequenceDictionary.getSequence(0).getSequenceName
val header = new SAMFileHeader
header.setSequenceDictionary(Header.getSequenceDictionary)
val intervalList = new IntervalList(header)
intervalList.add(new Interval(contig, 1, 10))
intervalList.write(path.toFile)
path
}

Observed in:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions