WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 470909e

Browse files
lcarteylcartey
authored
Merge pull request #887 from github/michaelrfairhurst/implement-cpp-package-floating-point
Implement package FloatingPoint
2 parents 0abfe4a + 714b5cc commit 470909e

32 files changed

+1564
-431
lines changed

c/misra/test/rules/DIR-4-15/PossibleMisuseOfUndetectedInfinity.expected renamed to c/common/test/rules/misuseofinfinitefloatingpointvalue/MisuseOfInfiniteFloatingPointValue.expected

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,30 @@
1+
problems
2+
| test.c:12:8:12:9 | l2 | test.c:8:14:8:20 | ... / ... | test.c:12:8:12:9 | l2 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
3+
| test.c:13:8:13:9 | l3 | test.c:8:14:8:20 | ... / ... | test.c:13:8:13:9 | l3 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
4+
| test.c:18:8:18:9 | l2 | test.c:8:14:8:20 | ... / ... | test.c:18:3:18:9 | l2 | Possibly infinite float value $@ flows to cast to integer. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
5+
| test.c:19:8:19:9 | l3 | test.c:8:14:8:20 | ... / ... | test.c:19:3:19:9 | l3 | Possibly infinite float value $@ flows to cast to integer. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
6+
| test.c:27:19:27:20 | l2 | test.c:8:14:8:20 | ... / ... | test.c:27:19:27:20 | l2 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
7+
| test.c:28:19:28:20 | l3 | test.c:8:14:8:20 | ... / ... | test.c:28:19:28:20 | l3 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
8+
| test.c:38:8:38:9 | l7 | test.c:31:14:32:15 | ... / ... | test.c:38:3:38:9 | l7 | Possibly infinite float value $@ flows to cast to integer. | test.c:31:14:32:15 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
9+
| test.c:61:11:61:17 | ... / ... | test.c:61:5:61:18 | ... / ... | test.c:61:5:61:18 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:61:11:61:17 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
10+
| test.c:66:11:66:19 | ... / ... | test.c:66:5:66:20 | ... / ... | test.c:66:5:66:20 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:66:11:66:19 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
11+
| test.c:72:20:72:28 | ... / ... | test.c:72:14:72:29 | ... / ... | test.c:72:14:72:29 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:72:20:72:28 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
12+
| test.c:75:24:75:32 | ... / ... | test.c:75:18:75:33 | ... / ... | test.c:75:18:75:33 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:75:24:75:32 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
13+
| test.c:79:10:79:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:79:5:79:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
14+
| test.c:87:10:87:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:87:5:87:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
15+
| test.c:91:10:91:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:91:5:91:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
16+
| test.c:93:10:93:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:93:5:93:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
17+
| test.c:99:10:99:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:99:5:99:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
18+
| test.c:105:10:105:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:105:5:105:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
19+
| test.c:111:10:111:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:111:5:111:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
20+
| test.c:114:21:114:23 | l12 | test.c:77:15:77:21 | ... / ... | test.c:114:16:114:23 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
21+
| test.c:117:28:117:30 | l12 | test.c:77:15:77:21 | ... / ... | test.c:117:23:117:30 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
22+
| test.c:120:25:120:27 | l12 | test.c:77:15:77:21 | ... / ... | test.c:120:20:120:27 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
23+
| test.c:163:9:164:15 | ... / ... | test.c:163:3:164:16 | ... / ... | test.c:163:3:164:16 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:163:9:164:15 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
24+
| test.c:175:32:175:32 | p | test.c:189:51:189:59 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:189:51:189:59 | ... / ... | from division by zero | test.c:189:6:189:24 | addInfThenCastToInt | addInfThenCastToInt |
25+
| test.c:175:32:175:32 | p | test.c:193:13:194:15 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:193:13:194:15 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
26+
| test.c:175:32:175:32 | p | test.c:204:19:204:27 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:204:19:204:27 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
27+
| test.c:185:18:185:18 | p | test.c:200:25:200:33 | ... / ... | test.c:185:13:185:18 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:200:25:200:33 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
128
edges
229
| test.c:8:14:8:20 | ... / ... | test.c:8:14:8:20 | ... / ... | provenance | |
330
| test.c:8:14:8:20 | ... / ... | test.c:9:14:9:16 | - ... | provenance | Config |
@@ -83,31 +110,4 @@ nodes
83110
| test.c:206:21:206:31 | ... + ... | semmle.label | ... + ... |
84111
| test.c:208:13:208:21 | middleInf | semmle.label | middleInf |
85112
| test.c:210:23:210:31 | middleInf | semmle.label | middleInf |
86-
subpaths
87-
#select
88-
| test.c:12:8:12:9 | l2 | test.c:8:14:8:20 | ... / ... | test.c:12:8:12:9 | l2 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
89-
| test.c:13:8:13:9 | l3 | test.c:8:14:8:20 | ... / ... | test.c:13:8:13:9 | l3 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
90-
| test.c:18:8:18:9 | l2 | test.c:8:14:8:20 | ... / ... | test.c:18:3:18:9 | l2 | Possibly infinite float value $@ flows to cast to integer. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
91-
| test.c:19:8:19:9 | l3 | test.c:8:14:8:20 | ... / ... | test.c:19:3:19:9 | l3 | Possibly infinite float value $@ flows to cast to integer. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
92-
| test.c:27:19:27:20 | l2 | test.c:8:14:8:20 | ... / ... | test.c:27:19:27:20 | l2 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
93-
| test.c:28:19:28:20 | l3 | test.c:8:14:8:20 | ... / ... | test.c:28:19:28:20 | l3 | Possibly infinite float value $@ flows to divisor, which would silently underflow and produce zero. | test.c:8:14:8:20 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
94-
| test.c:38:8:38:9 | l7 | test.c:31:14:32:15 | ... / ... | test.c:38:3:38:9 | l7 | Possibly infinite float value $@ flows to cast to integer. | test.c:31:14:32:15 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
95-
| test.c:61:11:61:17 | ... / ... | test.c:61:5:61:18 | ... / ... | test.c:61:5:61:18 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:61:11:61:17 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
96-
| test.c:66:11:66:19 | ... / ... | test.c:66:5:66:20 | ... / ... | test.c:66:5:66:20 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:66:11:66:19 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
97-
| test.c:72:20:72:28 | ... / ... | test.c:72:14:72:29 | ... / ... | test.c:72:14:72:29 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:72:20:72:28 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
98-
| test.c:75:24:75:32 | ... / ... | test.c:75:18:75:33 | ... / ... | test.c:75:18:75:33 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:75:24:75:32 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
99-
| test.c:79:10:79:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:79:5:79:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
100-
| test.c:87:10:87:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:87:5:87:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
101-
| test.c:91:10:91:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:91:5:91:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
102-
| test.c:93:10:93:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:93:5:93:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
103-
| test.c:99:10:99:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:99:5:99:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
104-
| test.c:105:10:105:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:105:5:105:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
105-
| test.c:111:10:111:12 | l12 | test.c:77:15:77:21 | ... / ... | test.c:111:5:111:12 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
106-
| test.c:114:21:114:23 | l12 | test.c:77:15:77:21 | ... / ... | test.c:114:16:114:23 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
107-
| test.c:117:28:117:30 | l12 | test.c:77:15:77:21 | ... / ... | test.c:117:23:117:30 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
108-
| test.c:120:25:120:27 | l12 | test.c:77:15:77:21 | ... / ... | test.c:120:20:120:27 | l12 | Possibly infinite float value $@ flows to cast to integer. | test.c:77:15:77:21 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
109-
| test.c:163:9:164:15 | ... / ... | test.c:163:3:164:16 | ... / ... | test.c:163:3:164:16 | ... / ... | Possibly infinite float value $@ flows to cast to integer. | test.c:163:9:164:15 | ... / ... | from division by zero | test.c:6:6:6:7 | f1 | f1 |
110-
| test.c:175:32:175:32 | p | test.c:189:51:189:59 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:189:51:189:59 | ... / ... | from division by zero | test.c:189:6:189:24 | addInfThenCastToInt | addInfThenCastToInt |
111-
| test.c:175:32:175:32 | p | test.c:193:13:194:15 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:193:13:194:15 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
112-
| test.c:175:32:175:32 | p | test.c:204:19:204:27 | ... / ... | test.c:175:27:175:32 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:204:19:204:27 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
113-
| test.c:185:18:185:18 | p | test.c:200:25:200:33 | ... / ... | test.c:185:13:185:18 | p | Possibly infinite float value $@ computed in function $@ flows to cast to integer. | test.c:200:25:200:33 | ... / ... | from division by zero | test.c:192:6:192:7 | f2 | f2 |
113+
subpaths

‎c/common/test/rules/misuseofinfinitefloatingpointvalue/MisuseOfInfiniteFloatingPointValue.ql‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// GENERATED FILE - DO NOT MODIFY
2+
import codingstandards.cpp.rules.misuseofinfinitefloatingpointvalue.MisuseOfInfiniteFloatingPointValue
3+
4+
class TestFileQuery extends MisuseOfInfiniteFloatingPointValueSharedQuery, TestQuery { }

c/misra/test/rules/DIR-4-15/test.c renamed to c/common/test/rules/misuseofinfinitefloatingpointvalue/test.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ void f1(float p1) {
3333
float l8 = 0.0 / 0.0;
3434

3535
(int)l4; // COMPLIANT
36-
(int)l5; // NON_COMPLIANT: Casting NaN to int
37-
(int)l6; // NON_COMPLIANT: Casting NaN to int
38-
(int)l7; // NON_COMPLIANT: Casting NaN to int
39-
(int)l8; // NON_COMPLIANT: Casting NaN to int
36+
(int)l5; // COMPLIANT: Casting NaN to int
37+
(int)l6; // COMPLIANT: Casting NaN to int
38+
(int)l7; // NON_COMPLIANT: Casting Infinity to int
39+
(int)l8; // COMPLIANT: Casting NaN to int
4040

4141
l4 == 0; // COMPLIANT
4242
l4 != 0; // COMPLIANT
@@ -58,21 +58,21 @@ void f1(float p1) {
5858
if (l9 != 0) {
5959
(int)(l9 / l9); // COMPLIANT: l9 is not zero
6060
} else {
61-
(int)(l9 / l9); // NON_COMPLIANT: Guarded to not be NaN
61+
(int)(l9 / l9); // NON_COMPLIANT[False positive]: Guarded to not be NaN
6262
}
6363

6464
float l10 = 0;
6565
if (l10 == 0) {
66-
(int)(l10 / l10); // NON_COMPLIANT: Casting NaN to integer
66+
(int)(l10 / l10); // NON_COMPLIANT[False positive]: Casting NaN to integer
6767
} else {
6868
(int)(l10 / l10); // COMPLIANT: Guarded to not be NaN
6969
}
7070

7171
float l11 = 0;
72-
l11 == 0 ? (int)(l11 / l11) : 0; // NON_COMPLIANT
72+
l11 == 0 ? (int)(l11 / l11) : 0; // NON_COMPLIANT[False positive]
7373
l11 == 0 ? 0 : (int)(l11 / l11); // COMPLIANT
7474
l11 != 0 ? (int)(l11 / l11) : 0; // COMPLIANT
75-
l11 != 0 ? 0 : (int)(l11 / l11); // NON_COMPLIANT
75+
l11 != 0 ? 0 : (int)(l11 / l11); // NON_COMPLIANT[False positive]
7676

7777
float l12 = 1.0 / 0;
7878
if (isinf(l12)) {
@@ -123,29 +123,29 @@ void f1(float p1) {
123123
if (isinf(l13)) {
124124
(int)l13; // COMPLIANT: Guarded not to be NaN
125125
} else {
126-
(int)l13; // NON_COMPLIANT: Casting NaN to integer
126+
(int)l13; // COMPLIANT: Casting NaN to integer
127127
}
128128

129129
if (isinf(l13) == 1) {
130130
(int)l13; // COMPLIANT: Guarded not to be NaN (must be +Infinity)
131131
} else {
132-
(int)l13; // NON_COMPLIANT: Casting NaN to integer
132+
(int)l13; // COMPLIANT: Casting NaN to integer
133133
}
134134

135135
if (isfinite(l13)) {
136136
(int)l13; // COMPLIANT: Guarded not to be NaN
137137
} else {
138-
(int)l13; // NON_COMPLIANT: Casting NaN to integer
138+
(int)l13; // COMPLIANT: Casting NaN to integer
139139
}
140140

141141
if (isnormal(l13)) {
142142
(int)l13; // COMPLIANT: Guarded not to be NaN
143143
} else {
144-
(int)l13; // NON_COMPLIANT: Casting NaN to integer
144+
(int)l13; // COMPLIANT: Casting NaN to integer
145145
}
146146

147147
if (isnan(l13)) {
148-
(int)l13; // NON_COMPLIANT: Casting NaN to integer
148+
(int)l13; // COMPLIANT: Casting NaN to integer
149149
} else {
150150
(int)l13; // COMPLIANT: Guarded not to be NaN
151151
}
@@ -154,21 +154,21 @@ void f1(float p1) {
154154
: 0; // COMPLIANT: Checked infinite, therefore not NaN, before use
155155
isinf(l13) ? 0 : (int)l13; // COMPLIANT: Check on wrong branch
156156
isfinite(l13) ? (int)l13 : 0; // COMPLIANT: Checked finite before use
157-
isfinite(l13) ? 0 : (int)l13; // NON_COMPLIANT: Checked on wrong branch
158-
isnan(l13) ? (int)l13 : 0; // NON_COMPLIANT: Check on wrong branch
157+
isfinite(l13) ? 0 : (int)l13; // COMPLIANT: Checked on wrong branch
158+
isnan(l13) ? (int)l13 : 0; // COMPLIANT: Check on wrong branch
159159
isnan(l13) ? 0 : (int)l13; // COMPLIANT: Checked not NaN before use
160160

161-
(int)pow(2, p1); // NON_COMPLIANT: likely to be Infinity
161+
(int)pow(2, p1); // NON_COMPLIANT[False negative]: likely to be Infinity
162162
(int)pow(2, sin(p1)); // COMPLIANT: not likely to be Infinity
163163
(int)(1 /
164164
sin(p1)); // NON_COMPLIANT: possible infinity from zero in denominator
165165
(int)(1 / log(p1)); // COMPLIANT: not possibly zero in denominator
166-
(int)pow(p1, p1); // NON_COMPLIANT: NaN if p1 is zero
166+
(int)pow(p1, p1); // COMPLIANT: NaN if p1 is zero
167167
if (p1 != 0) {
168168
(int)pow(p1, p1); // COMPLIANT: p1 is not zero
169169
}
170170

171-
(int)acos(p1); // NON_COMPLIANT: NaN if p1 is not within -1..1
171+
(int)acos(p1); // COMPLIANT: NaN if p1 is not within -1..1
172172
(int)acos(cos(p1)); // COMPLIANT: cos(p1) is within -1..1
173173
}
174174

@@ -192,21 +192,21 @@ void addNaNThenCastToInt(float p) { castToInt(p + 0.0 / 0.0); }
192192
void f2() {
193193
castToInt(1.0 /
194194
0.0); // NON_COMPLIANT: Infinity flows to denominator in division
195-
castToInt(0.0 / 0.0); // NON_COMPLIANT: NaN flows to denominator in division
195+
castToInt(0.0 / 0.0); // COMPLIANT
196196
checkBeforeCastToInt(1.0 / 0.0); // COMPLIANT
197197
checkBeforeCastToInt(0.0 / 0.0); // COMPLIANT
198198
addOneThenCastToInt(1.0 / 0.0); // NON_COMPLIANT[False negative]
199199
addOneThenCastToInt(0.0 / 0.0); // NON_COMPLIANT
200200
castToIntToFloatToInt(1.0 / 0.0); // NON_COMPLIANT
201-
castToIntToFloatToInt(0.0 / 0.0); // NON_COMPLIANT
201+
castToIntToFloatToInt(0.0 / 0.0); // COMPLIANT
202202

203203
// Check that during flow analysis, we only report the true root cause:
204204
float rootInf = 1.0 / 0.0;
205205
float rootNaN = 0.0 / 0.0;
206206
float middleInf = rootInf + 1;
207207
float middleNaN = rootNaN + 1;
208208
castToInt(middleInf); // NON_COMPLIANT
209-
castToInt(middleNaN); // NON_COMPLIANT
209+
castToInt(middleNaN); // COMPLIANT
210210
addInfThenCastToInt(middleInf); // NON_COMPLIANT
211-
addNaNThenCastToInt(middleNaN); // NON_COMPLIANT
211+
addNaNThenCastToInt(middleNaN); // COMPLIANT
212212
}

0 commit comments

Comments
 (0)