endpoints: FleetDM connector #18589
Open
endpoints: FleetDM connector #18589
+1,224
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Langhammer <[email protected]> # Conflicts: # blueprints/schema.json # schema.yml
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18589 +/- ##
==========================================
- Coverage 93.19% 93.06% -0.14%
==========================================
Files 929 934 +5
Lines 51174 51340 +166
==========================================
+ Hits 47692 47778 +86
- Misses 3482 3562 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-33274d48f0d09e37c2457537d18f9b551eda7a68
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-33274d48f0d09e37c2457537d18f9b551eda7a68Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
GirlBossRush
approved these changes
Dec 6, 2025
Comment on lines
24
to
28
| getSuccessMessage(): string { | ||
| return this.instance | ||
| ? msg("Successfully updated fleet connector.") | ||
| : msg("Successfully created fleet connector."); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| getSuccessMessage(): string { | |
| return this.instance | |
| ? msg("Successfully updated fleet connector.") | |
| : msg("Successfully created fleet connector."); | |
| } | |
| public override getSuccessMessage(): string { | |
| return this.instance | |
| ? msg("Successfully updated Fleet connector.") | |
| : msg("Successfully created Fleet connector."); | |
| } |
| name="name" | ||
| placeholder=${msg("Connector name...")} | ||
| label=${msg("Connector name")} | ||
| value=${ifDefined(this.instance?.name)} |
Contributor
There was a problem hiding this comment.
Suggested change
| value=${ifDefined(this.instance?.name)} | |
| value=${this.instance?.name ?? ""} |
Comment on lines
50
to
64
| <ak-form-element-horizontal name="enabled"> | ||
| <label class="pf-c-switch"> | ||
| <input | ||
| class="pf-c-switch__input" | ||
| type="checkbox" | ||
| ?checked=${this.instance?.enabled ?? true} | ||
| /> | ||
| <span class="pf-c-switch__toggle"> | ||
| <span class="pf-c-switch__toggle-icon"> | ||
| <i class="fas fa-check" aria-hidden="true"></i> | ||
| </span> | ||
| </span> | ||
| <span class="pf-c-switch__label">${msg("Enabled")}</span> | ||
| </label> | ||
| </ak-form-element-horizontal> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ak-form-element-horizontal name="enabled"> | |
| <label class="pf-c-switch"> | |
| <input | |
| class="pf-c-switch__input" | |
| type="checkbox" | |
| ?checked=${this.instance?.enabled ?? true} | |
| /> | |
| <span class="pf-c-switch__toggle"> | |
| <span class="pf-c-switch__toggle-icon"> | |
| <i class="fas fa-check" aria-hidden="true"></i> | |
| </span> | |
| </span> | |
| <span class="pf-c-switch__label">${msg("Enabled")}</span> | |
| </label> | |
| </ak-form-element-horizontal> | |
| <ak-switch-input | |
| name="enabled" | |
| label=${msg("Enable XZY")} | |
| ?checked=${this.instance?.enabled ?? true} | |
| help=${msg("....")} | |
| ></ak-switch-input> |
| @state() | ||
| protected error?: APIError; | ||
|
|
||
| static styles: CSSResult[] = [PFBase, PFCard, PFPage, PFGrid, PFButton, PFDescriptionList]; |
Contributor
There was a problem hiding this comment.
PFBase can be omitted since AKElement has a singleton it references when mounting
Suggested change
| static styles: CSSResult[] = [PFBase, PFCard, PFPage, PFGrid, PFButton, PFDescriptionList]; | |
| static styles: CSSResult[] = [PFCard, PFPage, PFGrid, PFButton, PFDescriptionList]; |
| } | ||
| } | ||
|
|
||
| updated(changed: PropertyValues<this>) { |
Contributor
There was a problem hiding this comment.
Suggested change
| updated(changed: PropertyValues<this>) { | |
| public override updated(changed: PropertyValues<this>) { |
| }); | ||
| } | ||
|
|
||
| renderTabOverview() { |
Contributor
There was a problem hiding this comment.
Suggested change
| renderTabOverview() { | |
| protected renderTabOverview() { |
Comment on lines
72
to
73
| const [appLabel, modelName] = | ||
| ModelEnum.AuthentikEndpointsConnectorsFleetFleetconnector.split("."); |
Contributor
There was a problem hiding this comment.
Can this be moved out of the element instance as a constant?
| tabindex="0" | ||
| slot="page-permissions" | ||
| id="page-permissions" | ||
| aria-label="${msg("Permissions")}" |
Contributor
There was a problem hiding this comment.
Suggested change
| aria-label="${msg("Permissions")}" | |
| aria-label=${msg("Permissions")} |
6 tasks
|
@GirlBossRush I've opened a new pull request, #18651, to work on those changes. Once the pull request is ready, I'll request review from you. |
Copilot AI
added a commit
that referenced
this pull request
Dec 6, 2025
Co-authored-by: GirlBossRush <[email protected]>
* Initial plan * Add public override modifiers to updated method Co-authored-by: GirlBossRush <[email protected]> * Address additional feedback from PR #18589 Co-authored-by: GirlBossRush <[email protected]> * Fix indentation in ak-switch-input component Co-authored-by: GirlBossRush <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: GirlBossRush <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]> # Conflicts: # schema.yml
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.