Add: nasl builtin plugin_run_synscan() #2055
Open
+392
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
jjnicola
force-pushed
the
builtin-tcpsyn
branch
from
e9a63a5 to
042c825
Compare
ArnoStiefvater
force-pushed
the
builtin-tcpsyn
branch
from
96001a6 to
41f6101
Compare
Tehforsch
reviewed
Dec 9, 2025
Contributor
Tehforsch
left a comment
Tehforsch
left a comment
There was a problem hiding this comment.
Nice, thank you! Some really minor comments
| socket2::Type::RAW, | ||
| Some(Protocol::from(IPPROTO_RAW)), | ||
| ) | ||
| // .map_err(|e| AliveTestError::NoSocket(e.to_string())) |
Comment on lines
+174
to
+175
| for port in ports.iter() { | ||
| count += 1; |
Contributor
There was a problem hiding this comment.
With this logic, count will never be anything other than ports.len(), so we might as well get rid of it.
| } | ||
|
|
||
| #[nasl_function] | ||
| async fn plugin_run_synscan(configs: &ScanCtx<'_>) -> Result<(), FnError> { |
Contributor
There was a problem hiding this comment.
Personal nitpick: I much prefer ctx or context as a variable name for ScanCtx because configs is imo simply misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add: nasl builtin plugin_run_synscan()
SC-1410
Why:
How:
Checklist: