-
Notifications
You must be signed in to change notification settings - Fork 4k
upgrade Bazel protobuf to 33.1 #12553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
81e72aa to
bbda349
Compare
726b60e to
d538b98
Compare
It looks like Android Interop Testing build needs some work to include Protobuf dependencies.
|
The Linux artifacts build is failing at :grpc-android-interop-testing:packageDebug with errors about missing protobuf Java classes. |
|
odd, since that job only involves gradle that I see. In fact, the full protobuf library that has those dependencies has been purposefully exluded for years; see
|
|
I created a scratch PR #12558 to see what happens if we don't exclude com.google.protobuf group as a transitive dependency in android-interop-testing build. It fails with errors It still doesn't answer from where it was getting the Protobuf deps when com.google.protobuf was excluded. |
d538b98 to
c9a8fa6
Compare
|
I think the problem is actually: I added |
Following up on 58ae5f8, change Bazel's view of the protobuf version to 33.1 too.
This is a bit of an adventure in the bzlmod/WORKSPACE compatibility maze. A few rulesets like
rules_javamust be upgraded too.C++ compilation must happen until C++17 now due to the new abseil version required.
Dependency on
rules_protois removed because it has become a superfluous wrapper over rules in the upstream protobuf repo.