WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Dec 5, 2025

Following up on 58ae5f8, change Bazel's view of the protobuf version to 33.1 too.

This is a bit of an adventure in the bzlmod/WORKSPACE compatibility maze. A few rulesets like rules_java must be upgraded too.

C++ compilation must happen until C++17 now due to the new abseil version required.

Dependency on rules_proto is removed because it has become a superfluous wrapper over rules in the upstream protobuf repo.

@benjaminp benjaminp force-pushed the bazel-protobuf branch 2 times, most recently from 81e72aa to bbda349 Compare December 5, 2025 23:32
@ejona86 ejona86 requested a review from kannanjgithub December 5, 2025 23:33
@benjaminp benjaminp force-pushed the bazel-protobuf branch 12 times, most recently from 726b60e to d538b98 Compare December 6, 2025 00:23
@kannanjgithub kannanjgithub added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 8, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 8, 2025
kannanjgithub
kannanjgithub previously approved these changes Dec 8, 2025
@kannanjgithub kannanjgithub dismissed their stale review December 8, 2025 12:54

It looks like Android Interop Testing build needs some work to include Protobuf dependencies.

@kannanjgithub
Copy link
Contributor

The Linux artifacts build is failing at :grpc-android-interop-testing:packageDebug with errors about missing protobuf Java classes.

@benjaminp
Copy link
Contributor Author

odd, since that job only involves gradle that I see.

In fact, the full protobuf library that has those dependencies has been purposefully exluded for years; see

exclude group: 'com.google.protobuf'
. So, anyone know how this ever worked?

@kannanjgithub
Copy link
Contributor

kannanjgithub commented Dec 9, 2025

I created a scratch PR #12558 to see what happens if we don't exclude com.google.protobuf group as a transitive dependency in android-interop-testing build. It fails with errors

Execution failed for task ':grpc-android-interop-testing:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class com.google.protobuf.AbstractMessageLite found in modules protobuf-java-3.25.8.jar -> protobuf-java-3.25.8 (com.google.protobuf:protobuf-java:3.25.8) and protobuf-javalite-3.25.8.jar -> protobuf-javalite-3.25.8 (com.google.protobuf:protobuf-javalite:3.25.8)

It still doesn't answer from where it was getting the Protobuf deps when com.google.protobuf was excluded.

@benjaminp
Copy link
Contributor Author

I think the problem is actually:

* What went wrong:
Execution failed for task ':grpc-android-interop-testing:packageDebug'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable

I added --stacktrace so maybe the actual error can be revealed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants