-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate fabric video to svelte #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual regression testing results 🔍If any tests are failing, please check that any visual changes are intentional before merging your PR.
|
2463675 to
9df688e
Compare
a1adcba to
60b0633
Compare
emma-imber
reviewed
Oct 24, 2024
e2c07b1 to
9f80b57
Compare
… child components
9f80b57 to
fa4fd96
Compare
4 tasks
emma-imber
reviewed
Oct 30, 2024
Jakeii
reviewed
Oct 30, 2024
Jakeii
reviewed
Nov 12, 2024
Jakeii
reviewed
Nov 12, 2024
Jakeii
reviewed
Nov 12, 2024
Jakeii
reviewed
Nov 12, 2024
Jakeii
reviewed
Nov 12, 2024
8ee21bd to
e2b7531
Compare
Jakeii
approved these changes
Nov 13, 2024
Member
Jakeii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Converts the Fabric Video template to Svelte.
Its important to note, we need to perform setup logic after the component renders.
subscribeto subscribe to a store, so we can perform actions whenever the value of the store changes.legacyfabric video to prevent it being detected by GAM.How to test
How can we measure success?
We can further check the functionality of the
pauseand theplaymethods by adding console.logs in the "observer" if and navigate the viewport in Preview so the fabric video is out of view.We have added the
IntersectionObserver, which is responsible for detecting when the video element enters the viewport and playing or pausing the video accordingly. Updating the previous functions in the legacy code.Have we considered potential risks?
Images
Screen.Recording.2024-10-21.at.12.40.58.mov
Accessibility
co-authored: @Jakeii