Attempt to accept english language cookie banners #229
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The webpage snapshot service is fairly unhelpful at the moment - it just takes a screenshot of a giant cookie banner.
Ways of avoiding this:
This is a crappy solution - we really need to get some 'see everything everyone does on every website' super powers for our chrome extension (or a different extension) and do the snapshot client side, but, in the meantime I think the risk of randomly navigating to an 'accept all' link is lower than the risk of taking a useless snapshot of a cookie banner.
Where this won't work
ACCEPT_COOKIES_TEXT🤦🏻How to test
This works on:
It doesn't work on:
...because they are using text other than 'accept all'.
Concerns
Security concerns - someone could put a malicious link in a button and our poor robot would blindly click it. Would this matter? I think it should be fine - the link is clicked inside the puppeteer browser and will be lost when the lambda finishes executing
Related work
#232