WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@philmcmahon
Copy link
Contributor

@philmcmahon philmcmahon commented Dec 4, 2025

What does this change?

The webpage snapshot service is fairly unhelpful at the moment - it just takes a screenshot of a giant cookie banner.

Ways of avoiding this:

  • Use Brave browser (this doesn't work on theguardian.com)
  • Use ublock origin with extra 'EasyList – Cookie Notices' list (this works on theguardian.com) - I tried this using ghostery but without success, maybe more research needed
  • Click the first or with the innerHTML 'accept all' - works for > 1 english language sites that I tried

This is a crappy solution - we really need to get some 'see everything everyone does on every website' super powers for our chrome extension (or a different extension) and do the snapshot client side, but, in the meantime I think the risk of randomly navigating to an 'accept all' link is lower than the risk of taking a useless snapshot of a cookie banner.

Where this won't work

  • anywhere where the accept button for the cookie banner says something not in ACCEPT_COOKIES_TEXT 🤦🏻

How to test

This works on:

  • youtube.com
  • theguardian.com

It doesn't work on:

  • facebook.com
  • x.com
  • lemonde.fr
    ...because they are using text other than 'accept all'.

Concerns

Security concerns - someone could put a malicious link in a button and our poor robot would blindly click it. Would this matter? I think it should be fine - the link is clicked inside the puppeteer browser and will be lost when the lambda finishes executing

Related work

#232

unsure dog

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants