WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

#attach deletes image after attaching #46

@jonstorer

Description

@jonstorer

The attach method deletes the image it just attached when it's done.

  • This should not be the responsibility of the library. The library should rely on express (or the system) to clean up its own tmp files.

My integration tests attach images to object. In tests, I have to read my fixture file, create a tmp file for it, then attach it since mongoose-attachments is going to delete it. That's a lot of overhead for something the library shouldn't be doing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions