fix: invalidate node maps when nodes change in-between paints #5694. #5746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dcebdba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
We have the same issue on our side, and this patch seems to solve it 👍 |
dylans
approved these changes
Oct 24, 2024
Collaborator
dylans
left a comment
dylans
left a comment
There was a problem hiding this comment.
Ok, this looks reasonable. Obviously if it causes any major regressions we may need to revert it.
Merged
RavenColEvol
pushed a commit
to RavenColEvol/slate
that referenced
this pull request
Mar 16, 2025
…mtaylor#5694. (ianstormtaylor#5746) * fix: invalidate node maps when nodes change in-between paints ianstormtaylor#5694. * Add patch changeset * Catch additional invalide reference on Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an editor crash where the user types quickly after earlier nodes have been added, split or deleted, but the node maps have not yet been regenerated on React render.
Issue
Fixes: (link to issue)
Example
Recording (from issue linked above)
https://github.com/user-attachments/assets/a68453b1-df47-4324-a542-9313569958ca
Sandbox (from issue linked above)
https://codesandbox.io/s/slate-selection-change-repro-ztssmp
Context
The
NODE_TO_INDEXWeakMap is built on each React render as part of theuseChildrenhook. BothonDOMBeforeInputandonDOMSelectionChangeuse these maps to set the selection. This change introduces a newWeakMapcalledIS_NODE_MAP_DIRTYto track whether the underlying nodes have changed (eg:remove_nodeorinsert_node), allowing those methods to skip attempts tosetSelectionthat could crash the component.Recommend you compare with "Ignore white space" selected.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)