WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Refactor file permissions #630

@tmorrell

Description

@tmorrell

Comment by @slint from #629

I think the confusion in general comes from the fact that _get_record(...) doesn't only do what's on the label, but also performs a permission check... Would it make sense to fix that and extract and repeat the logic in each service call to make things a bit more explicit/clear? Unfortunately, I see that we override _get_record(...) in rdm-records, to perform an extra permission check for deleted records. This should be done in the permissions class, and we shouldn't need can_read_deleted_files in the first place...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions