WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Nov 22, 2025

https://issues.jenkins.io/browse/JENKINS-76303

Adapt to jenkinsci/jenkins#11269 by allowing the domain hosting avatars as img-src in CSP.

Testing done

None. Plugin doesn't even compile for me, neither JDK 17 nor 21. Same error as in the PR build.

A basic interactive test with mvn hpi:run should allow confirming this works; as CSP is enforced in this mode.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 22, 2025
@daniel-beck daniel-beck marked this pull request as ready for review November 25, 2025 15:26
@mrmateo
Copy link

mrmateo commented Nov 26, 2025

None. Plugin doesn't even compile for me, neither JDK 17 nor 21. Same error as in the PR build.

Was able to get it building by updating to newer jenkins dependency versions (for the baseline, bom, and plugin) and then working through versioning between the keycloak transitive dependencies and what is provided by jackson2-api plugin and bouncycastle api plugin. I'll create a separate PR for the dependency updates to fix the builds with the newer jenkins version and then can verify that this PR builds before merging.

@daniel-beck
Copy link
Member Author

Plugin doesn't even compile for me

🤦 I somehow looked at the wrong build statuses and thought that was a pre-existing condition. Thanks for updating things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants