WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Api lock is acquired while processing a webhook such that payout webhooks can be processed synchronously
  • This could solve the concurrency issue since this will prevent multiple webhooks for the same payout_id to enter into critical section.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak self-assigned this Dec 3, 2025
@Sakilmostak Sakilmostak requested a review from a team as a code owner December 3, 2025 09:57
@Sakilmostak Sakilmostak added A-core Area: Core flows C-bug Category: Bug Payouts Area: Payouts labels Dec 3, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 3, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/webhooks/incoming.rs  0% smaller

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@8e33f24). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10523   +/-   ##
=======================================
  Coverage        ?    6.47%           
=======================================
  Files           ?     1251           
  Lines           ?   311475           
  Branches        ?        0           
=======================================
  Hits            ?    20165           
  Misses          ?   291310           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core flows C-bug Category: Bug Payouts Area: Payouts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants