WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Payout status in response should be dependent on intent rather than attempt for a given payout transaction

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak self-assigned this Dec 4, 2025
@Sakilmostak Sakilmostak requested a review from a team as a code owner December 4, 2025 08:25
@Sakilmostak Sakilmostak added A-core Area: Core flows C-bug Category: Bug Payouts Area: Payouts labels Dec 4, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 4, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payouts.rs  0% smaller

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@efea6a0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/router/src/core/payouts.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10534   +/-   ##
=======================================
  Coverage        ?    6.46%           
=======================================
  Files           ?     1251           
  Lines           ?   311700           
  Branches        ?        0           
=======================================
  Hits            ?    20164           
  Misses          ?   291536           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sakilmostak Sakilmostak requested review from a team as code owners December 4, 2025 13:10
@Sakilmostak Sakilmostak removed request for a team December 4, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core flows C-bug Category: Bug Payouts Area: Payouts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants