fix: Invoke UCS in shadow mode even when the HS request fails HS↔UCS tunnel #10544
+44
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10544 +/- ##
=======================================
Coverage ? 6.46%
=======================================
Files ? 1251
Lines ? 311796
Branches ? 0
=======================================
Hits ? 20164
Misses ? 291632
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+8666
to
+8669
| let direct_router_data = match &result { | ||
| Ok(success_data) => Some(success_data.0.clone()), | ||
| Err(_) => None, | ||
| }; |
Contributor
There was a problem hiding this comment.
should we not compare the router data if HS call fails???
Contributor
Author
There was a problem hiding this comment.
in error case we will not get the updated router data so there is no need to compare them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Enhanced shadow UCS (Unified Connector Service) testing to execute even when the primary HS (Hyperswitch) direct connector call fails. This ensures comprehensive comparison data is collected for all payment flows, improving observability and shadow testing accuracy.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy