feat: allow specifying registry network in configuration #1627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows users to specify a network to be used when creating a registry via a configuration file.
Example:
Furthermore, a test was added to ensure that the "network" property is read from the config file. The documentation has been updated to let users know about this option.
This PR doesn't add the ability to specify a network via the
--registry-createoption.I wasn't sure if this change required a new JSON schema version. Since this is not a breaking change, I decided to just add the property to the existing
v1alpha5schema.Why
Fixes #1162.
Originally posted by @ar3s3ru in #1162
This is very useful for users using Podman. With this PR, they can create a bridge network beforehand and, in the config, use that network to create the registry (as recommended in the docs).
Implications
No breaking changes. If the network option is not specified, the "bridge" network remains the default.