WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

Parent Issue #2688

  • Created the KiwixDataStore and SharedPreferenceToDatastoreMigrator classes to handle the migration of existing SharedPreferences data to DataStore.
  • Migrated the currently opened ZIM file and the currently opened tab to DataStore.
  • Migrated the TextZoom value to DataStore (the zoom level configured by the user for reading ZIM files).
  • Added DataStore dependency in our project.

* Created the `KiwixDataStore` and `SharedPreferenceToDatastoreMigrator` classes to handle the migration of existing `SharedPreferences` data to `DataStore`.
* Migrated the currently opened ZIM file and the currently opened tab to `DataStore`.
* Migrated the `TextZoom` value to `DataStore` (the zoom level configured by the user for reading ZIM files).
* Added `DataStore` dependency in our project.
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 77.46479% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.93%. Comparing base (0b14cf6) to head (e039c30).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kiwixmobile/core/main/reader/CoreReaderFragment.kt 33.33% 0 Missing and 6 partials ⚠️
...kiwixmobile/core/utils/datastore/KiwixDataStore.kt 77.27% 2 Missing and 3 partials ⚠️
...wix/kiwixmobile/core/settings/SettingsPresenter.kt 42.85% 4 Missing ⚠️
...bile/nav/destination/reader/KiwixReaderFragment.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4514      +/-   ##
============================================
- Coverage     58.96%   58.93%   -0.03%     
- Complexity     1520     1531      +11     
============================================
  Files           324      327       +3     
  Lines         17500    17535      +35     
  Branches       2179     2180       +1     
============================================
+ Hits          10318    10334      +16     
- Misses         5757     5768      +11     
- Partials       1425     1433       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42 kelson42 merged commit 12b7344 into main Dec 9, 2025
35 checks passed
@kelson42 kelson42 deleted the Fixes#2688 branch December 9, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants