🐛 Fix JVM proxy args passing

[aufi]

Proxy setting with -Djava...Proxies=true was placed in args after jar which was most likely ignored by JVM.

Changing its order to ensure its understood correctly by JVM running jdtls.

Replaces konveyor/java-analyzer-bundle#173

Fixes: konveyor/java-analyzer-bundle#172

Summary by CodeRabbit

• Bug Fixes
  • Fixed Java application launcher argument ordering to ensure system proxy settings are correctly applied before the application runs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The Java launcher command in the external provider is modified to ensure JVM system properties are positioned before the -jar argument. This change moves -Djava.net.useSystemProxies=true ahead of -jar jarPath, ensuring proxy settings are applied to the JVM rather than passed to the application.

Changes

Cohort / File(s)	Change Summary
Java launcher argument reordering external-providers/java-external-provider/pkg/java_external_provider/provider.go	Reordered Java command arguments to place -Djava.net.useSystemProxies=true before -jar jarPath, ensuring JVM system properties are correctly processed by the launcher.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single argument reordering in one file
• Verify that moving -jar after the system property doesn't introduce unintended side effects in argument parsing

Poem

🐰 A little rabbit hops with glee,
Arguments rearranged, so the JVM runs free!
Proxy settings now in place, before the jar takes flight—
External providers configured just right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR addresses the core requirement from issue #172 by ensuring proxy settings are positioned correctly in JVM arguments so jdtls can access external resources.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to reordering a single argument in the Java launcher command, directly addressing the linked issue without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and concisely describes the main change: fixing the order of JVM proxy arguments to ensure the proxy setting is correctly recognized by the JVM launcher.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shawn-hurley]

If this is working in a test environment, then please ignore this.

But I wanted to know whether we also needed to explicitly add the environment to the command here: https://github.com/konveyor/analyzer-lsp/pull/978/files#diff-2430297ef0a9e63ec1a282c9ba2b450043754ad1efc7fe73cd9b54045e5fa724R409

If we don't have a test environment that can test proxied environments easily/automated, can we can add an issue tracking this in the CI repo?

[shawn-hurley]

@aufi go ahead and merge when you are ready!