WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 1691509

Browse files
committed
addressing code rabbit comments
Signed-off-by: Shawn Hurley <[email protected]>
1 parent 4de9ff2 commit 1691509

File tree

7 files changed

+317
-162
lines changed

7 files changed

+317
-162
lines changed

.github/workflows/integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
- name: Run Phase 2 integration tests in container
7070
run: |
7171
podman run --rm \
72-
-v $(pwd)/java-analyzer-bundle.test:/tests:Z \
72+
-v "$(pwd)/java-analyzer-bundle.test:/tests:Z" \
7373
-e WORKSPACE_DIR=/tests/projects \
7474
-e JDTLS_PATH=/jdtls \
7575
--workdir /tests/integration \

.gitignore

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,9 @@ target/
44
*.iml
55
.DS_Store
66
.gradle/
7-
*/projects/.metadata
7+
8+
# Eclipse metadata
9+
**/.metadata/
10+
.classpath
11+
.project
12+
.settings/

java-analyzer-bundle.test/docs/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Welcome to the Java Analyzer Bundle test documentation. This directory contains
88
**Best for**: Getting started, quick lookups, command reference
99

1010
A condensed guide with:
11-
- Coverage summary (8/15 location types)
11+
- Coverage summary (15/15 location types - 100% ✅)
1212
- Test execution commands
1313
- Expected output examples
1414
- Key test patterns and wildcards
@@ -76,7 +76,7 @@ Detailed overview of the Java test projects:
7676

7777
### I want to add a new test
7878
[Integration Tests Guide - Adding New Tests](integration-tests.md#adding-new-tests)
79-
[Query Reference - Untested Query Patterns](query-reference.md#untested-query-patterns)
79+
[Query Reference - All Tested Patterns](query-reference.md#tested-search-queries)
8080

8181
### I want to understand the architecture
8282
[Integration Tests Guide - Architecture](integration-tests.md#architecture)
@@ -257,7 +257,7 @@ README.md (you are here)
257257
### Advanced: Adding/Debugging Tests
258258
1. Read [Integration Tests - Architecture](integration-tests.md#architecture)
259259
2. Read [Integration Tests - Components](integration-tests.md#components)
260-
3. Study [Query Reference - Untested Patterns](query-reference.md#untested-query-patterns)
260+
3. Study [Query Reference - All Tested Patterns](query-reference.md#tested-search-queries)
261261
4. Review [Integration Tests - Adding New Tests](integration-tests.md#adding-new-tests)
262262
5. Add new test function and verify
263263

0 commit comments

Comments
 (0)