-
|
Somehow there are releases, like https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/tag/v0.8.0, which don't include previously merged PRs, like #1648. Is this a mistake? Or what is the concept here? |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 5 replies
-
|
It looks like #1648 is included in v0.8.0, or am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
Is it? It's at least not in the changelog |
Beta Was this translation helpful? Give feedback.
-
|
Ah, I can see it in v0.7.3...v0.8.0 So it's just a bug in the changelog generation? |
Beta Was this translation helpful? Give feedback.
-
|
It was more of a choice in changelog generation, tbh: I decided not to repeat the changelogs between pre-releases. However, it sounds like I should reconsider that. |
Beta Was this translation helpful? Give feedback.
-
|
That would be great, I'd assume most people, like me, just watch for full releases and don't look at the prereleases |
Beta Was this translation helpful? Give feedback.
-
|
I agree with @cwrau here and would personally prefer the following behaviour:
This would result in some repetition, but as an end user I am primarily interested in changes between versions I am genuinely using and those are by and large only major ones. A nice side-effect is that contributors see their contribution included in a "real" major release, rather than mostly pre-releases. |
Beta Was this translation helpful? Give feedback.
-
|
To summarise the above: the issue was that although was fixed in the release, it was only mentioned in a pre-release release note rather than the actual release notes. For future releases:
We should document this decision in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/RELEASE.md so the release monkey doesn't forget! Any volunteer? |
Beta Was this translation helpful? Give feedback.
-
I'd be happy to take a look at this in the coming days. |
Beta Was this translation helpful? Give feedback.
To summarise the above: the issue was that although was fixed in the release, it was only mentioned in a pre-release release note rather than the actual release notes.
For future releases:
We should document this decision in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/RELEASE.md so the release monkey doesn't forget! Any volunteer?