WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

extraArgs should not be sorted alpha-numerically #3261

@neolit123

Description

@neolit123

as discussed here:
https://kubernetes.slack.com/archives/C2P1JHS2E/p1763768847151629

the flag for the kube-apiserver --service-account-issuer has an order that matters.

When this flag is specified multiple times, the first is used to generate tokens and all are used to determine which issuers are accepted.

as it stands today, kubeadm will correctly override the base args but will end up sorting the entire list.
instead it should only sort the base and keep the order provided by the user for extraArgs.

that workaround for that is to use patches instead of extraArgs.

  • a fix should be backported to >=1.32
  • this can result in a diff for kubeadm upgrade in component manifests, which should be fine
  • it might disrupt some users applying patches on top of extraArgs, but that's a bit of a corner case

Metadata

Metadata

Assignees

Labels

area/apikind/bugCategorizes issue or PR as related to a bug.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions