Chore: Tests: Make renderBlockImages.test.ts less likely to fail in CI

Author: personalizedrefrigerator

packages/editor/CodeMirror/extensions/rendering/renderBlockImages.test.ts

@@ -9,12 +9,12 @@ const allowImageUrlsToBeFetched = async () => {
 	await Promise.resolve();
 };
 
-const createEditor = async (initialMarkdown: string, hasImage: boolean) => {
+const createEditor = async (initialMarkdown: string, expectedTags: string[] = ['Image']) => {
 	const resolveImageSrc = jest.fn((src, counter) => Promise.resolve(`${src}?r=${counter}`));
 	const editor = await createTestEditor(
 		initialMarkdown,
 		EditorSelection.cursor(0),
-		hasImage ? ['Image'] : [],
+		expectedTags,
 		[renderBlockImages({ resolveImageSrc })],
 	);
 	await allowImageUrlsToBeFetched();
@@ -40,7 +40,7 @@ describe('renderBlockImages', () => {
 		{ spaceBefore: '   ', spaceAfter: ' ', alt: 'test' },
 		{ spaceBefore: '', spaceAfter: '', alt: '!!!!' },
 	])('should render images below their Markdown source (case %#)', async ({ spaceBefore, spaceAfter, alt }) => {
-		const editor = await createEditor(`${spaceBefore}![${alt}](:/0123456789abcdef0123456789abcdef)${spaceAfter}`, true);
+		const editor = await createEditor(`${spaceBefore}![${alt}](:/0123456789abcdef0123456789abcdef)${spaceAfter}`);
 
 		const images = findImages(editor);
 		expect(images).toHaveLength(1);
@@ -51,13 +51,13 @@ describe('renderBlockImages', () => {
 	// For now, only Joplin resources are rendered. This simplifies the implementation and avoids
 	// potentially-unwanted web requests when opening a note with only the editor open.
 	test('should not render web images', async () => {
-		const editor = await createEditor('![test](https://example.com/test.png)\n\n', true);
+		const editor = await createEditor('![test](https://example.com/test.png)\n\n');
 		const images = findImages(editor);
 		expect(images).toHaveLength(0);
 	});
 
 	test('should allow reloading specific images', async () => {
-		const editor = await createEditor('![test](:/a123456789abcdef0123456789abcdef)\n![test 2](:/b123456789abcdef0123456789abcde2)', true);
+		const editor = await createEditor('![test](:/a123456789abcdef0123456789abcdef)\n![test 2](:/b123456789abcdef0123456789abcde2)');
 
 		// Should have the expected original image URLs
 		expect(getImageUrls(editor)).toMatchObject([
@@ -98,7 +98,7 @@ describe('renderBlockImages', () => {
 		const widthAttr = width ? ` width="${width}"` : '';
 		const editor = await createEditor(
 			`${spaceBefore}<img src=":/0123456789abcdef0123456789abcdef" alt="${alt}"${widthAttr} />${spaceAfter}`,
-			false,
+			['HTMLTag'],
 		);
 
 		const images = findImages(editor);
@@ -117,7 +117,7 @@ describe('renderBlockImages', () => {
 	test('should render non-self-closing HTML img tags', async () => {
 		const editor = await createEditor(
 			'<img src=":/0123456789abcdef0123456789abcdef" alt="test" width="300">',
-			false,
+			['HTMLBlock'],
 		);
 
 		const images = findImages(editor);
@@ -128,7 +128,7 @@ describe('renderBlockImages', () => {
 	test('should not render HTML img tags with web URLs', async () => {
 		const editor = await createEditor(
 			'<img src="https://example.com/test.png" alt="test" />',
-			false,
+			['HTMLTag'],
 		);
 
 		const images = findImages(editor);
@@ -138,7 +138,7 @@ describe('renderBlockImages', () => {
 	test('should render both markdown and HTML images in same document', async () => {
 		const editor = await createEditor(
 			'![markdown](:/a123456789abcdef0123456789abcdef)\n\n<img src=":/b123456789abcdef0123456789abcde2" alt="html" width="400" />',
-			true,
+			['Image', 'HTMLTag'],
 		);
 
 		const images = findImages(editor);
@@ -151,7 +151,7 @@ describe('renderBlockImages', () => {
 		const editor = await createEditor(
 			// eslint-disable-next-line quotes
 			"<img src=':/0123456789abcdef0123456789abcdef' alt='test' width='250' />",
-			false,
+			['HTMLTag'],
 		);
 
 		const images = findImages(editor);