Mobile: Fixes #13825: Fix incompatible plugins cannot be uninstalled #13828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjo118
changed the title
Collaborator
|
Thank you for fixing this! |
laurent22
reviewed
Dec 1, 2025
| onPress={props.onShowPluginInfo ? onPress : null} | ||
| testID='plugin-card' | ||
| disabled={!props.isCompatible} | ||
| disabled={false} |
Owner
There was a problem hiding this comment.
Disabled is an optional property so I think we can just remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the install from file option on the plugins screen of both the native app and web app, install a plugin which is not compatible with mobile, eg. https://joplinapp.org/plugins/plugin/joplin-plugin-conflict-resolution/
It is then not possible to uninstall the plugin, because clicking the plugin tile or the 'incompatible' label on the tile does not do anything, due to being in a disabled state.
This is due to a regression introduced by #13234, which incorrectly disables the state of the CardButton when the plugin is incompatible. This PR fixes the issue by ensuring the CardButton is always enabled.
This fixes #13825
Testing
See video:
firefox_qn6VawwUWj.mp4
Clicking the 'incompatible' label now also works correctly