Bad Performance

[orhnk]

Files contain >4000 loc (when satellite is enabled) have big impact on performance

satellite-nvim-showcase-2023-08-21_06.52.04.mp4

#45

[lewis6991]

Sorry, not enough information.

[orhnk]

I didn't mention this because it was a bug in my config/system etc.
The plugin just needs to improve performance overall!

Just try it on a "big" file and you'll reproduce.

[justinmk]

Just try it on a "big" file and you'll reproduce.

Can reproduce on a 10K lines markdown file.

[lewis6991]

Test case?

[justinmk]

Most noticeable for me on https://github.com/justinmk/notes/blob/master/delicious.md but haven't narrowed down minimal steps. :syntax off and vim.treesitter.stop() don't fix it, only :SatelliteDisable

[lewis6991]

I can barely open that file with a minimal config. It completely locks up with set breakindent, and even after disabling that it is still really slow with all my plugins disabled (including Satellite).

We can explore adding some optimizations in places so massively long lines can be handled better, but whatever we do the functionality provided by this plugin is never going to be free.

[justinmk]

Graceful degradation would be totally acceptable and avoids needing to manually :SatelliteDisable.

[lewis6991]

Hmm, I can't replicate with:

vim.opt.rtp:prepend '/Users/lewrus01/projects/satellite.nvim'
require('satellite').setup()

vim --clean -u min.lua delicious.md

[justinmk]

Ok I'll try to narrow it down

[orhnk]

could you remove the invalid flag from the issue and reopen it?

[lewis6991]

We've not determined anything yet. The initial description contained no useful information other than "bad performance".

Tbh, I'm not really sure why Justin commented here as it seems his issues are with very specific non-normal files.