v3.0.0: Breaking upgrade to Xperience by Kentico v30.12.0 + build improvements #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add src/wwwroot/scripts/resource-checker.js to .gitignore - Remove previously committed resource-checker.js from git tracking - Update package-lock.json (npm install with node >=22 engine requirement) The resource-checker.js in wwwroot/scripts is a webpack build artifact from src/Client/src/resource-checker.js and should not be committed. It's already built during CI/CD by the npm run build command. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
BREAKING CHANGES: - Minimum required Xperience version is now 30.12.0 - SustainabilityTabProperties now inherits from WebPageBaseClientProperties instead of TemplateClientProperties (fixes compilation error) Updates: - Upgraded all Kentico packages from 30.4.2 to 30.12.0 - Updated @Kentico npm packages to 30.12.0 in client - Upgraded DancingGoat example app to v30.12.0 - Updated README Library Version Matrix Version bumped from 2.7.1 to 3.0.0 due to breaking changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the XperienceCommunity.Sustainability library to version 3.0.0 with breaking changes requiring Xperience by Kentico v30.12.0 or higher, along with build process improvements and bug fixes.
Key Changes:
- Upgraded all Kentico packages from v30.4.2 to v30.12.0 (breaking change)
- Fixed
SustainabilityTabPropertiesinheritance to useWebPageBaseClientPropertiesinstead ofTemplateClientProperties - Improved build process by adding client build artifacts to
.gitignoreand standardizing Node.js version requirements - Updated GitHub Actions workflows to build client assets before .NET build
Reviewed changes
Copilot reviewed 184 out of 189 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/wwwroot/scripts/resource-checker.js | Removed generated client build artifact |
| src/packages.lock.json | Updated Kentico package dependencies from 30.4.2 to 30.12.0 |
| src/XperienceCommunity.Sustainability.csproj | Bumped version to 3.0.0 and removed unnecessary folder include |
| src/UIPages/SustainabilityTab/SustainabilityTab.cs | Changed base class to WebPageBaseClientProperties |
| src/Client/package.json | Updated Kentico npm packages to 30.12.0 |
| examples/DancingGoat/* | Updated DancingGoat example app to v30.12.0 with commerce and email builder improvements |
| README.md | Updated version matrix to reflect breaking changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes breaking changes, build process improvements, and bug fixes for v3.0.0.
Breaking Changes
Minimum Xperience Version: v30.12.0
SustainabilityTabProperties Base Class Change
SustainabilityTabPropertiesto inherit fromWebPageBaseClientPropertiesinstead ofTemplateClientPropertiesBuild Process Improvements
Client Build Artifacts (.gitignore)
src/Client/dist/*to .gitignoresrc/wwwroot/scripts/resource-checker.jsto .gitignore.gitkeepto preservesrc/wwwroot/scripts/directory structure<Folder Include="wwwroot\scripts\" />from .csproj (no longer needed)GitHub Actions Workflows
npm ciandnpm run buildsteps for client assetsNode Version Standardization
.nvmrcfile specifying Node 22enginesfield to package.json requiring Node >=22Package Updates
Backend (NuGet)
Kentico.Xperience.WebApp: 30.4.2 → 30.12.0Kentico.Xperience.Admin: 30.4.2 → 30.12.0Kentico.Xperience.AzureStorage: 30.4.2 → 30.12.0Kentico.Xperience.ImageProcessing: 30.4.2 → 30.12.0Frontend (npm)
@kentico/xperience-admin-base: 30.4.2 → 30.12.0@kentico/xperience-admin-components: 30.4.2 → 30.12.0@kentico/xperience-webpack-config: 30.4.2 → 30.12.0Documentation Updates
>= 30.12.0→ Library v3.x>= 30.4.2→ Library v1.x - 2.xVersion Bump
Migration Guide
Users upgrading from v2.x to v3.0.0 must:
dotnet add package XperienceCommunity.Sustainability --version 3.0.0Related PRs
This builds on #67 (initial build artifact improvements)
🤖 Generated with Claude Code