GetRecordError::QuorumFailed never got raised ?

[maqi]

Scanned through the rust-libp2p repository, seems the GetRecordError::QuorumFailed never got raised ?

Assuming the network only have two nodes holding the required record, and there is a network kad::get_record got fired with Quorum set to 3
Will there be just: a sequence of: 2 GetRecordOk + 1 FinishedWithNoAdditionalRecord events to be notified ?

If QuorumFailed does got used, with the same above scenario, will it be raised as a separate event, with records field holding records from the two holders?
will the 2 GetRecordOk events still to be raised separately? will the FinishedWithNoAdditionalRecord event still to be raised to mark the completion ?

[drHuangMHT]

ping @guillaumemichel

[guillaumemichel]

I am not very familiar with these implementation details. You can probably find the behavior of this corner case in the code.

[maqi]

You can probably find the behavior of this corner case in the code

hmm..., unfortunately, that's the question: I can't find it (the error) got used in the code :(

[jxs]

Hi Maqi! Thanks for opening this, yeah the Quorum was removed on #2712 when switching to an iterative approach, but the GetRecordError::QuorumFailed was left dangling. I am curious though, how are you specifying the Quorum on kad::get_record?
Meanwhile submitted #6106

[maqi]

Hi, @jxs , thx for the update.

Right, so this error does become dangling as suspected, and agree with your #6106 to remove it.

how are you specifying the Quorum on kad::get_record

We thought the global configure of ReplicationFactor will be used, however it seems a false intercept.
The QuorumFailed error does gave us such impression, or it might the same dangling stuff left over from old tryouts, but become outdated now.