Deduplicate package check in ensurePro method
#2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhanley
changed the title
ensurePro methodensurePro method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario
When reviewing the
FluxManagerclass, I noticed that theensurePro()method directly callsInstalledVersions::isInstalled('livewire/flux-pro')to check if Flux Pro is installed, while there's already a dedicatedpro()method that performs the same check.The problem
deduplicate package check in
ensurePromethodThe solution
Refactor
ensurePro()to call the existingpro()method instead of duplicating the package checkFixes livewire/flux#