WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@rhdedgar
Copy link
Contributor

@rhdedgar rhdedgar commented Dec 3, 2025

What does this PR do?

Enables lllama-stack multi-architecture builds for ARM. The result is an image index, that will point to the image associated with the calling user's architecture.

On Kubernetes for example, with these changes, images are still referred to in the same manner, but will resolve to the architecture that is relevant to the node where it is to be run.

                                              --> quay.io/<user>/distribution-starter/<version>-linux-arm64
quay.io/<user>/distribution-starter/<version>-|
                                              --> quay.io/<user>/distribution-starter/<version>-linux-amd64

In practice, referring to the usual docker.io/llamastack/distribution-starter:latest should resolve to the image with the requesting user's relevant architecture, without any additional configuration on the user's side.

Closes #406

Test Plan

Tested container builds on an amd64 architecture host, and deployed the starter distribution image via llama-stack-k8s-operator to an arm64 architecture OpenShift cluster. The deployment ran and the operator's e2e test suite completed as expected.

Arm64-specific build tests run and pass on GitHub.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 3, 2025
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! ❤️

@@ -0,0 +1,166 @@
# syntax=docker/dockerfile:1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is almost a duplicate of the other one. could we auto-generate them if we need them both or have some other way of unifying them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, +1 to that. Just removing the recent additions of TARGETPLATFORM and BUILDPLATFORM was enough to make the Containerfile work for Podman as well. I've removed the duplicate Containerfile.podman addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload arm64 docker images where relevant

2 participants