Page connection won’t be saved

[MatzeKitt]

Describe the bug
The settings to connect two pages of different blocks don’t work for me. The submit button on the meta box does nothing and if I save the page and reload, the settings of MSLS are reset, unfortunately.

There’s nothing in the console, no error in the network tab and no log in the debug.log.

It seems to be the same issue as in #134. I can reproduce it locally and remote on production.

To Reproduce
Steps to reproduce the behavior:

1. Select a connected page in a different language
2. Update the page to save changes
3. Reload the editor

Expected behaviour
The settings are saved.

Screenshots

Bildschirmaufnahme.2022-03-27.um.15.49.15.mp4

Environment (please complete the following information):

• OS: macOS
• Browser: Safari/Chrome
• PHP Version: 7.4
• Plugin Version: 2.4.12

[MatzeKitt]

After a little further trial and error I noticed that the plugin doesn’t like it if there are multiple sites with the same language.

For me, I have two different sites in German and want to make them available in English, too. But in the same multisite. I now use the filter msls_blog_collection_construct to get only the relevant other site by its URL. This seem to be working. But I would love to see proper support for such a variation in the plugin itself. Or at least an error message. 😄

[apermo]

Hey @MatzeKitt I've dug through all open issues and I think your case is related to this feature request.

#400
Can you work with that?

[MatzeKitt]

Maybe. Since my filter works as expected for me, I have no plan to test the mentioned variant.

[lloc]

This could be the right moment to handle connections in the site's network admin and not relying on the blogs_of_user. The blog_collection object could be still the place to handle the information that might be stored in site_meta or similar.