-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add window visibility percentage to frames and search API #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@onehassan is attempting to deploy a commit to the louis030195's projects Team on Vercel. A member of the Team first needs to authorize it. |
🧪 testing bounty created!a testing bounty has been created for this PR: view testing issue testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements. |
|
this is cool and probably better than previous focus detection solution does it work on windows and linux? would like some testers |
description
This PR introduces a new
visible_percentagefield to the frames table, enabling us to track and query how much of a window is visible on the screen. It includes updates across the migrations, Rust data structures, APIs, to support this feature. Visibility calculations consider the positions and overlap of multiple windows.This enhancement is particularly useful when using the
--capture-unfocused-windowsflag. It allows users to precisely filter and distinguish search results based on the actual visibility of unfocused windows, greatly enhancing precision and relevance in scenarios with overlapping windows.how to test
./target/release/screenpipe --disable-audio --enable-frame-cache --capture-unfocused-windowsvisible_percentagefield reflects the correct visibility percentage.min_visible_percentageandmax_visible_percentageand verify correct filtering