WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@onehassan
Copy link

@onehassan onehassan commented Mar 18, 2025

description

This PR introduces a new visible_percentage field to the frames table, enabling us to track and query how much of a window is visible on the screen. It includes updates across the migrations, Rust data structures, APIs, to support this feature. Visibility calculations consider the positions and overlap of multiple windows.

This enhancement is particularly useful when using the --capture-unfocused-windows flag. It allows users to precisely filter and distinguish search results based on the actual visibility of unfocused windows, greatly enhancing precision and relevance in scenarios with overlapping windows.

how to test

  1. Build screenpipe and run it with the --capture-unfocused-windows flag
    ./target/release/screenpipe --disable-audio --enable-frame-cache --capture-unfocused-windows
  2. Capture frames while windows overlap and verify that the visible_percentage field reflects the correct visibility percentage.
  3. Perform searches with visibility filters using the new parameters min_visible_percentage and max_visible_percentage and verify correct filtering

CleanShot 2025-03-18 at 20 48 05@2x

@vercel
Copy link

vercel bot commented Mar 18, 2025

@onehassan is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

🧪 testing bounty created!

a testing bounty has been created for this PR: view testing issue

testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements.

@louis030195
Copy link
Collaborator

this is cool and probably better than previous focus detection solution

does it work on windows and linux?

would like some testers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants