WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 8847fa9

Browse files
Fix clipped Hyperlink focus rectangle on Typography page (#2061)
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR adds a top margin to prevent the Hyperlink focus rectangle from being clipped on the Typography page. ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes #1928. ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Manually ran the app and confirmed the change. ## Screenshots (if appropriate): Current: <img width="847" height="149" alt="image" src="https://github.com/user-attachments/assets/7c5a9c8e-2953-4c79-acba-ef1470ce43af" /> New: <img width="851" height="142" alt="image" src="https://github.com/user-attachments/assets/6095e641-5ae9-4809-b5db-9c4197e29a2b" /> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) Co-authored-by: Niels Laute <[email protected]>
1 parent 06d8c16 commit 8847fa9

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

WinUIGallery/Samples/ControlPages/Design/TypographyPage.xaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,13 @@
3737
<RowDefinition Height="Auto" />
3838
<RowDefinition Height="*" />
3939
</Grid.RowDefinitions>
40-
<RichTextBlock>
40+
<!-- This top margin prevents the Hyperlink focus rectangle from being clipped. -->
41+
<RichTextBlock Margin="0,4,0,0">
4142
<Paragraph>
42-
Typography helps provide structure and hierarchy to UI. The default font for Windows is <Hyperlink NavigateUri="https://learn.microsoft.com/windows/apps/design/downloads/#fonts">Segoe UI Variable</Hyperlink>.
43-
Best practice is to use Regular weight for most text, use Semibold for titles. The minimum values should be 12px Regular, 14px Semibold.</Paragraph>
43+
Typography helps provide structure and hierarchy to UI. The default font for Windows is
44+
<Hyperlink NavigateUri="https://learn.microsoft.com/windows/apps/design/downloads/#fonts">Segoe UI Variable</Hyperlink> .
45+
Best practice is to use Regular weight for most text, use Semibold for titles. The minimum values should be 12px Regular, 14px Semibold.
46+
</Paragraph>
4447
</RichTextBlock>
4548
<controls:ControlExample
4649
x:Name="Example1"

0 commit comments

Comments
 (0)