Refactor ProcessHandler arguments logic (#4711)

* Move PH classes to folder & update namespaces

* wip: refactor PH args processing modes

* Add wrapper to get cmd args

* Correct knob descriptions

* Add debug log for args mode

* Fix file mode logic

* Use switch/case

* fix variables naming

* Return old handler and move new to v2

* Get temp by hostcontext

* Fix tests on visual studio

* Added tests

Author: localconst

src/Agent.Sdk/Knob/AgentKnobs.cs

@@ -534,11 +534,17 @@ public class AgentKnobs
 
         public static readonly Knob ProcessHandlerEnableNewLogic = new Knob(
             nameof(ProcessHandlerEnableNewLogic),
-            "Enables new sanitization logic for process handler",
+            "Enables new args protect logic for process handler",
             new RuntimeKnobSource("AZP_75787_ENABLE_NEW_PH_LOGIC"),
             new EnvironmentKnobSource("AZP_75787_ENABLE_NEW_PH_LOGIC"),
             new BuiltInDefaultKnobSource("false"));
 
+        public static readonly Knob UseProcessHandlerV2 = new Knob(
+            nameof(UseProcessHandlerV2),
+            "Enables new Process handler (v2)",
+            new RuntimeKnobSource("AGENT_USE_PROCESS_HANDLER_V2"),
+            new BuiltInDefaultKnobSource("false"));
+
         public static readonly Knob DisableDrainQueuesAfterTask = new Knob(
             nameof(DisableDrainQueuesAfterTask),
             "Forces the agent to disable draining queues after each task",

src/Agent.Worker/Handlers/HandlerFactory.cs

@@ -93,7 +93,16 @@ public IHandler Create(
             else if (data is ProcessHandlerData)
             {
                 // Process.
-                handler = HostContext.CreateService<IProcessHandler>();
+                if (AgentKnobs.UseProcessHandlerV2.GetValue(executionContext).AsBoolean())
+                {
+                    Trace.Info("Using ProcessHandlerV2");
+                    handler = HostContext.CreateService<IProcessHandlerV2>();
+                }
+                else
+                {
+                    handler = HostContext.CreateService<IProcessHandler>();
+                }
+
                 (handler as IProcessHandler).Data = data as ProcessHandlerData;
             }
             else if (data is PowerShellHandlerData)

src/Agent.Worker/Handlers/Helpers/CmdArgsSanitizer.cs renamed to src/Agent.Worker/Handlers/ProcessHandler/CmdArgsSanitizer.cs

@@ -6,7 +6,7 @@
 using System.Text.RegularExpressions;
 using Microsoft.VisualStudio.Services.Agent.Util;
 
-namespace Agent.Worker.Handlers.Helpers
+namespace Microsoft.VisualStudio.Services.Agent.Worker.Handlers
 {
     public static class CmdArgsSanitizer
     {

src/Agent.Worker/Handlers/ProcessHandler/Exceptions.cs

@@ -0,0 +1,14 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+using System;
+
+namespace Microsoft.VisualStudio.Services.Agent.Worker.Handlers
+{
+    public class InvalidScriptArgsException : Exception
+    {
+        public InvalidScriptArgsException(string message) : base(message)
+        {
+        }
+    }
+}

src/Agent.Worker/Handlers/ProcessHandler.cs renamed to src/Agent.Worker/Handlers/ProcessHandler/ProcessHandler.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 using Agent.Sdk.Knob;
-using Agent.Worker.Handlers.Helpers;
 using Microsoft.VisualStudio.Services.Agent.Util;
 using Newtonsoft.Json;
 using System;
@@ -365,11 +364,4 @@ private void OnOutputDataReceived(object sender, ProcessDataReceivedEventArgs e)
             }
         }
     }
-
-    public class InvalidScriptArgsException : Exception
-    {
-        public InvalidScriptArgsException(string message) : base(message)
-        {
-        }
-    }
 }

src/Agent.Worker/Handlers/Helpers/ProcessHandlerHelper.cs renamed to src/Agent.Worker/Handlers/ProcessHandler/ProcessHandlerHelper.cs

@@ -5,10 +5,9 @@
 using System.Collections.Generic;
 using Agent.Sdk.Knob;
 using Microsoft.VisualStudio.Services.Agent.Util;
-using Microsoft.VisualStudio.Services.Agent.Worker;
 using Microsoft.VisualStudio.Services.Common;
 
-namespace Agent.Worker.Handlers.Helpers
+namespace Microsoft.VisualStudio.Services.Agent.Worker.Handlers
 {
     public static class ProcessHandlerHelper
     {
@@ -152,6 +151,39 @@ public static (bool, Dictionary<string, object>) ValidateInputArguments(
                 return (true, null);
             }
         }
+
+        public static (bool, Dictionary<string, object>) ValidateInputArgumentsV2(
+            IExecutionContext context,
+            string inputArgs,
+            Dictionary<string, string> environment,
+            bool canIncludeTelemetry)
+        {
+            context.Debug("Starting args env expansion");
+            var (expandedArgs, envExpandTelemetry) = ExpandCmdEnv(inputArgs, environment);
+            context.Debug($"Expanded args={expandedArgs}");
+
+            context.Debug("Starting args sanitization");
+            var (sanitizedArgs, sanitizationTelemetry) = CmdArgsSanitizer.SanitizeArguments(expandedArgs);
+
+            if (sanitizedArgs != inputArgs)
+            {
+                Dictionary<string, object> telemetry = null;
+                if (canIncludeTelemetry)
+                {
+                    telemetry = envExpandTelemetry.ToDictionary();
+                    if (sanitizationTelemetry != null)
+                    {
+                        telemetry.AddRange(sanitizationTelemetry.ToDictionary());
+                    }
+                }
+                if (sanitizedArgs != expandedArgs)
+                {
+                    return (false, telemetry);
+                }
+            }
+
+            return (true, null);
+        }
     }
 
     public class CmdTelemetry