Poor contrast with default light on dark theme

[Forge36]

Minimal setup

(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)

(setq use-package-enable-imenu-support t)
(unless (package-installed-p 'use-package)
  (package-install 'use-package))
(require 'use-package)


;; Themeing: dark mode - light on dark
(set-foreground-color "white")
(set-background-color "black")

(use-package corfu
  :ensure t
  ;; Intellisense-like completion
  :init
  (global-corfu-mode)
  (corfu-popupinfo-mode)
  :custom
  (corfu-auto t)
  (corfu-scroll-margin 2))

Suspected problematic code:

(defface corfu-default
  '((((class color) (min-colors 88) (background dark)) :background "#191a1b")
    (((class color) (min-colors 88) (background light)) :background "#f0f0f0")
    (t :background "gray"))
  "Default face, foreground and background colors used for the popup.")

Expected:

Actual:

Easy enough to customize with

'(corfu-default ((t (:background "#191a1b" :foreground "white")))))

[minad]

The Corfu face only adjusts the background such that the background is different from the default black/white. However the default foreground should still be sufficiently different.

Note that the face detects if the theme is a dark or light theme. Your recipe code is not proper themeing, since it makes it impossible to detect if the current theme is dark or light:

(set-foreground-color "white")
(set-background-color "black")

For well-made themes, I suggest to take a look at the modus-themes or the ef-themes.

[Forge36]

Interesting. I think I'd gotten this from: https://www.reddit.com/r/emacs/comments/byvjo1/comment/eqpgmk2/

Which tarsius suggests is one of emac's default themes.

I can be slightly more compliant by adding

(add-to-list 'default-frame-alist '(foreground-color . "white"))
(add-to-list 'default-frame-alist '(background-color . "black"))

[minad]

The problem might be that the color is not changed for all frames? You could try:

(set-face-attribute 'default nil :background "black" :foreground "white")

[Forge36]

That's neater than the 4 lines I was going to use and looks identical. Ill go with that. Thanks!