WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit e6bc263

Browse files
authored
Merge pull request #2730 from cliffhall/ensure-create-release-is-run-on-any-publish
Fix insufficient create-release condition in GitHub Action
2 parents f4a2540 + 8881844 commit e6bc263

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,12 @@ jobs:
193193

194194
create-release:
195195
needs: [update-packages, create-metadata, publish-pypi, publish-npm]
196-
if: needs.update-packages.outputs.changes_made == 'true'
196+
if: |
197+
# Always evaluate this condition, even if a dependency failed
198+
# Create a release if changes were made and at least one publish succeeded
199+
always() &&
200+
needs.update-packages.outputs.changes_made == 'true' &&
201+
(needs.publish-pypi.result == 'success' || needs.publish-npm.result == 'success')
197202
runs-on: ubuntu-latest
198203
environment: release
199204
permissions:

0 commit comments

Comments
 (0)