WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit f968145

Browse files
wenxuwan文徐
andauthored
add stack (#1132)
Co-authored-by: 文徐 <[email protected]>
1 parent c101016 commit f968145

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

components/rpc/invoker/mosn/mosninvoker.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"encoding/json"
2222
"errors"
2323
"fmt"
24+
"runtime/debug"
2425
"strconv"
2526

2627
// bridge to mosn
@@ -87,7 +88,7 @@ func (m *mosnInvoker) Init(conf rpc.RpcConfig) error {
8788
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
8889
defer func() {
8990
if r := recover(); r != nil {
90-
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
91+
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
9192
log.DefaultLogger.Errorf("%v", err)
9293
}
9394
}()

components/rpc/invoker/mosn/mosninvoker_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ func Test_mosnInvoker_Invoke(t *testing.T) {
126126
}
127127
_, err := invoker.Invoke(context.Background(), req)
128128
assert.NotNil(t, err)
129-
assert.Equal(t, "[runtime][rpc]mosn invoker panic: runtime error: invalid memory address or nil pointer dereference", err.Error())
129+
assert.NotNil(t, err)
130130
})
131131
}
132132

docs/blog/code/layotto-rpc/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ mosn.io/layotto/components/rpc/invoker/mosn.(*mosnInvoker).Invoke at mosninvoker
406406
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
407407
defer func() {
408408
if r := recover(); r != nil {
409-
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
409+
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
410410
log.DefaultLogger.Errorf("%v", err)
411411
}
412412
}()

docs/i18n/en-US/docusaurus-plugin-content-blog/code/layotto-rpc/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ mosn.io/layotto/components/rpc/invoker/mosn.(*mosnInvoker).Invoke at mosninvoker
407407
func (m *mosnInvoker) Invoke(ctx context.Context, req *rpc.RPCRequest) (resp *rpc.RPCResponse, err error) {
408408
defer func() {
409409
if r := recover(); r != nil {
410-
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v", r)
410+
err = fmt.Errorf("[runtime][rpc]mosn invoker panic: %v, stack info: %+v", r, string(debug.Stack()))
411411
log.DefaultLogger.Errorf("%v", err)
412412
}
413413
}()

0 commit comments

Comments
 (0)