feat: Relax type constraints around ServiceBuilder::start
#1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addressed the issue reported: nats-io#1401 One test has been modified to prove that `version` should no longer need to be same type as `name` for a service.
Author
Jarema
requested changes
Nov 28, 2025
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
Thanks for the PR!
However, I would change the names of generic to N for name and V for version for better readibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addressed the issue reported: #1401
One test has been modified to prove that
versionshould no longer need to be same type asnamefor a service.