Fixed bug for work dirs longer than 255 characters, fixes #2061 (#3495)

* Fixed bug for work dirs longer than 255 characters

This change is fully backwards compatible and will
not affect existing pipelines, but it will prevent
the pipeline engine from crashing when some parameters
are long and it was trying to create subdirectories
longer than 255 characters (a typical unix limit).

Author: prioux

nipype/pipeline/engine/nodes.py

@@ -293,9 +293,12 @@ def output_dir(self):
         if self._hierarchy:
             outputdir = op.join(outputdir, *self._hierarchy.split("."))
         if self.parameterization:
-            params_str = ["{}".format(p) for p in self.parameterization]
-            if not str2bool(self.config["execution"]["parameterize_dirs"]):
-                params_str = [_parameterization_dir(p) for p in params_str]
+            maxlen = (
+                252 if str2bool(self.config["execution"]["parameterize_dirs"]) else 32
+            )
+            params_str = [
+                _parameterization_dir(str(p), maxlen) for p in self.parameterization
+            ]
             outputdir = op.join(outputdir, *params_str)
 
         self._output_dir = op.realpath(op.join(outputdir, self.name))

nipype/pipeline/engine/utils.py

@@ -51,14 +51,14 @@
 logger = logging.getLogger("nipype.workflow")
 
 
-def _parameterization_dir(param):
+def _parameterization_dir(param, maxlen):
     """
     Returns the directory name for the given parameterization string as follows:
-        - If the parameterization is longer than 32 characters, then
+        - If the parameterization is longer than maxlen characters, then
           return the SHA-1 hex digest.
         - Otherwise, return the parameterization unchanged.
     """
-    if len(param) > 32:
+    if len(param) > maxlen:
         return sha1(param.encode()).hexdigest()
     return param